From owner-cvs-ports@FreeBSD.ORG Sat Aug 13 22:43:40 2011 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 03AF01065673; Sat, 13 Aug 2011 22:43:40 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from mouf.net (mouf.net [204.109.58.86]) by mx1.freebsd.org (Postfix) with ESMTP id 9531B8FC0A; Sat, 13 Aug 2011 22:43:39 +0000 (UTC) Received: from meatwad.mouf.net (cpe-065-190-149-241.nc.res.rr.com [65.190.149.241]) (authenticated bits=0) by mouf.net (8.14.4/8.14.4) with ESMTP id p7DMhG1i065341 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NOT); Sat, 13 Aug 2011 18:43:17 -0400 (EDT) (envelope-from swills@FreeBSD.org) Message-ID: <4E46FE03.8070707@FreeBSD.org> Date: Sat, 13 Aug 2011 18:43:15 -0400 From: Steve Wills User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.17) Gecko/20110531 Thunderbird/3.1.10 MIME-Version: 1.0 To: Doug Barton References: <201108131428.p7DESYAh016813@repoman.freebsd.org> <4E46F4A7.8030300@FreeBSD.org> In-Reply-To: <4E46F4A7.8030300@FreeBSD.org> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (mouf.net [204.109.58.86]); Sat, 13 Aug 2011 18:43:17 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.96.2 at mouf.net X-Virus-Status: Clean Cc: Russell Jackson , cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/sysutils Makefile ports/sysutils/mcollective Makefile distinfo pkg-descr pkg-plist ports/sysutils/mcollective/files mcollectived.in X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Aug 2011 22:43:40 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Doug, On 08/13/11 18:03, Doug Barton wrote: > Before I forget, please don't obfuscate e-mail addresses in commit > messages. It does absolutely nothing to slow down the spammers, however > it does slow people down when they need to copy the e-mail address and > paste it into an actual e-mail. addport does this, but I'll try to catch it until it's updated. > This rc.d script has a lot of problems, and should not have been > committed as is, if for no other reason than it needs %%PREFIX%% instead > of /usr/local in command=. I've attached a patch that addresses the > following issues. It would also be helpful to visit > http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html > to familiarize yourself with the basic requirements. > > 1. Add a $FreeBSD$ > 2. Unless there is a good reason, ports rc.d scripts should REQUIRE: LOGIN. This one is my fault, not the submitters. > 3. Add the comments suggested in the web page above. > 4. Move load_rc_config up to what will soon become the standard location. > 5. s#/usr/local#%%PREFIX%%# > 6. Since the -p option is almost certainly mandatory here, use > command_args instead of _flags. > > Thanks for the patch, it's committed. I'll try to review these more closely in the future. Steve -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iQEcBAEBAgAGBQJORv4DAAoJEPXPYrMgexuhpmkH/0ZZyk6qxPldyMzZVDXV6AVu WeLbVjzVIPEjQKO//IWjJfiQ30KdVGjaB6B5cgxZvanRcpZ3d/QH6UBz+KP2epGB K0hq8JoBmp9MbwVDyddzJldbByWK50tIvtuXbyrTeGVMmaGJX2+mGHT5N+Ss3Xqt npyG+eVHwQjCGIkwFqXHYOxU3O1FWHMu9BZOA4vN0eUZfoNX4m68W/aeknF4K2eo G093AZBFbzlm9RMLZ5JPRw3dfP6pG1QLyko7eyreFS8xEDOHzXGZalai2gi5yB9q aM/YmNg75NZTnoLofOOwhcB7zu3dkcJ9Py7ERfw+WrQlahBWDVJoJc61x89xStI= =pheZ -----END PGP SIGNATURE-----