From owner-cvs-all@FreeBSD.ORG  Thu Oct  9 05:39:12 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6200C16A4B3; Thu,  9 Oct 2003 05:39:12 -0700 (PDT)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 76AC943FF5; Thu,  9 Oct 2003 05:39:07 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id WAA02580;
	Thu, 9 Oct 2003 22:39:02 +1000
Date: Thu, 9 Oct 2003 22:37:27 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: "Jacques A. Vidrine" <nectar@freebsd.org>
In-Reply-To: <20031009121355.GD94235@madman.celabo.org>
Message-ID: <20031009222521.W9649@gamplex.bde.org>
References: <200310090945.h999jKns055269@repoman.freebsd.org>
 <20031009121355.GD94235@madman.celabo.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: Hiten Pandya <hmp@freebsd.org>
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
cc: cvs-src@freebsd.org
Subject: Re: cvs commit: src/lib/libufs bread.3 cgread.3 getino.3 libufs.3
 sbread.3 ufs_disk_close.3
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Oct 2003 12:39:12 -0000

On Thu, 9 Oct 2003, Jacques A. Vidrine wrote:

> On Thu, Oct 09, 2003 at 02:45:20AM -0700, Hiten Pandya wrote:
> > hmp         2003/10/09 02:45:20 PDT
> >
> >   FreeBSD src repository (doc committer)
> >
> >   Modified files:
> >     lib/libufs           bread.3 cgread.3 getino.3 libufs.3
> >                          sbread.3 ufs_disk_close.3
> >   Log:
> >   Remove unneccessary include of sys/types.h in the SYNOPSIS
> >   header.
> >
> >   Sys/param.h includes sys/types.h internally unless LOCORE is
> >   defined.

Including both is also a style bug.

> I think you removed the wrong header.  Is <sys/param.h> required in
> each of these cases?  If not, then I believe the synopsis should refer
> only to <sys/types.h>:

<sys/param.h> is a prerequisite for <sys/mount.h> and some of the other
headers.  <sys/mount.h> is a prerequisite for <ufs/ufs/ufsmount.h>,
but the mount headers are not needed for much if anything in these
interfaces.  <sys/param.h> is only needed to define MAXBSIZE otherwise.

getino.3 might be more useful if it were installed.

Bruce