From owner-freebsd-smp  Sun Sep  7 15:38:14 1997
Return-Path: <owner-freebsd-smp>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id PAA15129
          for smp-outgoing; Sun, 7 Sep 1997 15:38:14 -0700 (PDT)
Received: from usr04.primenet.com (tlambert@usr04.primenet.com [206.165.6.204])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id PAA14992;
          Sun, 7 Sep 1997 15:36:09 -0700 (PDT)
Received: (from tlambert@localhost)
	by usr04.primenet.com (8.8.5/8.8.5) id PAA22637;
	Sun, 7 Sep 1997 15:36:08 -0700 (MST)
From: Terry Lambert <tlambert@primenet.com>
Message-Id: <199709072236.PAA22637@usr04.primenet.com>
Subject: Re: machine/up.h
To: smp@csn.net (Steve Passe)
Date: Sun, 7 Sep 1997 22:36:07 +0000 (GMT)
Cc: smp@freebsd.org, cvs-committers@freebsd.org, cvs-all@freebsd.org,
        cvs-CVSROOT@freebsd.org
In-Reply-To: <199709072037.OAA27121@Ilsa.StevesCafe.com> from "Steve Passe" at Sep 7, 97 02:37:40 pm
X-Mailer: ELM [version 2.4 PL23]
Content-Type: text
Sender: owner-freebsd-smp@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

> I propose that we create an alternate file to smp.h named up.h.
> 
> code could then look like:
> 
> #ifdef SMP
> #include <machine/smp.h>
> #else
> #include <machine/up.h>
> #endif
> 
> I could then move stuff like:
> 
> #ifndef SMP
> #define THIS_LOCK	/* nop this out for UP */
> #define THAT_FEATURE	/* nop this out for UP */
> #endif
> 
> from individual files and gather them all up into up.h  This should cause less
> disturbance to the source tree than the current methods.
> 
> Any objections?

Or you could include smp.h always, and do this in smp.h:

#ifdef SMP
#define	THIS_LOCK	smp_thislock	/* or whatever*/
...
#else	/* !SMP*/
#define	THIS_LOCK	/* NOP this out for non-SMP*
#endif

And have even less impact.

Or you could make the standard headers do the work for you, and not include
smp.h at all.  8-).


					Terry Lambert
					terry@lambert.org
---
Any opinions in this posting are my own and not those of my present
or previous employers.