Date: Thu, 21 Jan 2021 02:18:31 GMT From: Jessica Clarke <jrtc27@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 85ad7f8da19f - main - virtio_mmio: Delete a stale #if 0'ed debug print Message-ID: <202101210218.10L2IVEE018612@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by jrtc27: URL: https://cgit.FreeBSD.org/src/commit/?id=85ad7f8da19fbd5985690d4ccfcc45952713dd1b commit 85ad7f8da19fbd5985690d4ccfcc45952713dd1b Author: Jessica Clarke <jrtc27@FreeBSD.org> AuthorDate: 2021-01-21 02:14:41 +0000 Commit: Jessica Clarke <jrtc27@FreeBSD.org> CommitDate: 2021-01-21 02:14:41 +0000 virtio_mmio: Delete a stale #if 0'ed debug print This was blindly moved in r360722 but the variable being printed is not yet initialised. It's of little use and can easily be added back in the right place if needed by someone debugging, so just delete it. Reported by: bryanv --- sys/dev/virtio/mmio/virtio_mmio.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/sys/dev/virtio/mmio/virtio_mmio.c b/sys/dev/virtio/mmio/virtio_mmio.c index 862272b917df..5672a6f0f69c 100644 --- a/sys/dev/virtio/mmio/virtio_mmio.c +++ b/sys/dev/virtio/mmio/virtio_mmio.c @@ -478,10 +478,7 @@ vtmmio_set_virtqueue(struct vtmmio_softc *sc, struct virtqueue *vq, vm_paddr_t paddr; vtmmio_write_config_4(sc, VIRTIO_MMIO_QUEUE_NUM, size); -#if 0 - device_printf(dev, "virtqueue paddr 0x%08lx\n", - (uint64_t)paddr); -#endif + if (sc->vtmmio_version == 1) { vtmmio_write_config_4(sc, VIRTIO_MMIO_QUEUE_ALIGN, VIRTIO_MMIO_VRING_ALIGN);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202101210218.10L2IVEE018612>