From nobody Fri Jul 11 19:06:50 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bf1Rf2smCz61hdm for ; Fri, 11 Jul 2025 19:07:10 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic314-20.consmr.mail.gq1.yahoo.com (sonic314-20.consmr.mail.gq1.yahoo.com [98.137.69.83]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4bf1Rf0QsQz3PXx for ; Fri, 11 Jul 2025 19:07:09 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b="VY4/dbc2"; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.69.83 as permitted sender) smtp.mailfrom=marklmi@yahoo.com; dmarc=pass (policy=reject) header.from=yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1752260823; bh=wOi8/F5mOAcj4osliJMJjuWyxOjGe9un+1n+X74GPI0=; h=From:Subject:Date:To:References:From:Subject:Reply-To; b=VY4/dbc2ZQ28EL+YW86Df+DmT3y1aaAyZTbHaFh7gWA5767rTuzrNzYBGsLGyCy7Ge66cjGzAg6sQPNda1ds3b/LC06oLNuv7hCrLXRKm90qG8a0kwsYDYsoRkpwmD6s+itsNsXaul18sAg97MUdKzTSiTdZNtwYyckjN4G8y4HVbMJCmdtrYdhavQ5Ib2LCvu/pixlzh64y/Adcey8tLQNddEI2MeHpmxzK+KOfD6e4pti/ZyKx5/73MSzKcuYC0noQUeQyETpIuleCAqleIkBAGKRS1RLflDVblPFE2FxSo9ArOWtvyhAvqpXr43QQM1lK2rR+dd9HiR28awl/LA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1752260823; bh=o13ingWVjhdNOxdTZE9eegumWZyedwksOWJ2TPfxI7F=; h=X-Sonic-MF:From:Subject:Date:To:From:Subject; b=TeyCswhuUq4UTu6dwQ17kE6zvVBdAfdNWkETp9VYcxwBuTzHZgjxX71B4dtkielbyOC/Dj/0kNKW0vBe+96q24c9yRhwkspPoAqpkZEy4l1XVkeaJ09PA7XFnt8GAqIGfe0PGw/aoQ6vKSdd4oXif2RjLOT9KsHwccL1YeLWKQo2wdYQgicfMvBtbWFM5574o4ozewnm+SsjR4IKNZMt8LVN/OwIjfl0AFaYE4CH+OLwp7EYYEtl2zDQnhH1u67IrPE2/ylbXwJ8jFHot+iNmYO6+29ysflZDvR15DipXWWtLPTz9x5NgSzT2mmGJj7fVteRj2iMQpZJYnz8DzjwOQ== X-YMail-OSG: qf.XsA8VM1n6z2qFX5oOdDfKnbzKX6CJePq73J_6RSziRzOhkvEwNEjB6KxfuoE ph6T3OEk.QhpmzjD0gesG9Dpb1pWENgn7fsJjeksjNMUzGn9krrhHxZy7zHr3v1VlB2VlA3sa8jH q9gjh2B3iRTzbqq944Kfrs3.fV4pRy1wljdk5IQrc0strDQYuASnGr0kzPJhSkV2_a_d1ja2EQ7R tq3P0s.3CUS84ihTZ2.GhbCdj7a4c65wYzyL.DXj3gaLX4tvTUyKYIoo40fhFJ1iU6pHHzsNi4Wl sYzFM6vmDwfF.xI1mIx0LLNK2Ulp5szlzBNxRK9ciBipgH_1KZ5zgfd4VsdhBgds21qBmJmWQDj8 yPV_4O6h18WjL4xC9CWRrQm_eRUfoj0NgR6bqVMbWcAEIZwybCDfHFkC3voRtyXzicU3F7GBl3sV 5j9vPWq6rdp5tXOEV83h5i4od2PrSZQm4RfutnWQOhEUFO538WsN5Ao8Ex2JetdRNeiykx.FyzFl s_iJDkyuaQvbnH3DfWIp9KSDolmUK7JJ2gjnHuwzEGKkSeXpjU0AAj80_Bh_58OZZg_Xu5s.lBVX xEiN48cId.DqAk.6vUDJHVdn6lW_X5.v_GPgn8nfS1GobY4qjtO9YhIgOOeKN1SRgEInV3ex9blU 3cBhlgVc2mQBlRrcGvP13tZ6XonaIz5bJKGKZ.BRmghsmPt35SxPzJ9wDZYhGzVYgulA4DDhvh8d x6Pqnr_5Wi7GT6WNrJQJm4jK9eyc8sgWhqFNO5dkqTNvU9hSNegOAzu20cV4WGv_mjb2Et4hnEkN ULWUgNs2h2csVFTjG0KR1RBNkU9XIWwZyrr24LV5bLbEcX24PDkuMltN1tc.v3jjfDprZlHY5oTM mCK7W3PU2viQH3hUqXrMkGplcZ99ubBqmMtjq7oRmB8YXraRxjg.60aSslQLdL_3eHTmd.Ou.07d UPpCBZrAlH2sE9GxbVnkEmSL8R5qymih9Py3gtw3dzRikf3ASZDBjjTyzJ8YQMb3RsFyjfmvKHSI yG1LqZZ3JWtQ4LJdDTUdI4j.txKlHAHURGuEpQ0O7MPMw.8I_U8LGqY8J.aQlA8l2zMvh3p8VmcP p2_sVQVJCfp4PSB75XAeLCoUrPjbFQynfNygtL6frgGzc4KVIJCmV_i62kZY.pO.wwmiuLAJPEfr eLqtuaHUaNl1YG1ECHoF4vFonLLW98rlHumsSKkMarij_zGTP8YeRNMCAYVEm2IdmOzMCe4BvRM2 27HnoowGootdDN5Af5u.FfNVu9XPiG5E4JDQR_yb0RnTx6zpKIbkxaBe3vKydM.6kDXXKKruKTPr KuoKQBruoX9vutMT6G4lHQqC2hrCMsY7IO.Gcc08q5cjEGAHRWXzuimZMxG7krl8lLXNbQZN5msX 8CiPb1JfnaQBzHcZEqMcuz4fyTIxcJximmpXvYTcei.o_kAd3zZAMCuuuuPSYjTSL7kT2XuACSBE 25jcFuE2G8wa2AL6DjB6pO0UGg9uFNWhGdTy6TwA1ytYcJ5eLImAdN_byDyPfAZNzob0DJZQpQ_X cQvhPJIuMh9hSasJJdBvJl7o9xB2LHZn0TBhFF5ff38EuQf8kAL6mR60ZA_zeZLekmOM1jOXYEGe yt4_6NJGhAA_Dbbz.adF17_50IxfK74uYXV0Xxhav3GzBPbovkEy6baw0.B3v3SgaPqBWvJXTrUd e.Gt2t3Gzy5tciCrVJUPtecYf0vjo1OQWPxRP5wkxu_zqzfzg8mayNCwN06aOZMDzmaep2Pta7aM LNW99nMiS43AIvDlf1ZVPDHnV6XOxdiiIyFWsB8Cwyw3gyv5docHN1mWMJLoZKclRSOHODlaFGSe 1BKBEzR2vlWB4UEceE2f1HPXYfqMPgtnWPyzYM3XffvyjUfKKagFRy5PbdPX0UThLrEiuFXa_8F6 gTmrhavn4k6fGtEPvjcuxev6lPfD.1YHt7iokDzpgTG6gGgQoGgvj5EhxOaun8ciX8GAWnxkZqvd sheYHpxrfAP5XiXqYvnfHuj._kSMRaX3LL4RKhxtodDNCbX3hGAF.7TyXHL6RWGSksHDHFq2Id.g dAb4TiGmuGmQ.nI8QCOFZ26sUiAqTIh5IR9hPf6tQe1zZ4NiHCTizomea3kf2W.M9_mj9oy_rg3g uGyEXbznWD.4iGYpdsBiAtthaSsVHt6GVDk1FgbqCeR_5eV7hbW_EwDemPzQu9aFhaerdYJKj6.5 ihtcCdCNKVpdPzop2cCxkb9xTvoAs2mrVzIMp20P5und7jg-- X-Sonic-MF: X-Sonic-ID: 2b04b0f6-694a-45e5-86e9-f7f60afd6ea5 Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.gq1.yahoo.com with HTTP; Fri, 11 Jul 2025 19:07:03 +0000 Received: by hermes--production-gq1-74d64bb7d7-x7xzm (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID adcecd013f611c9a737c1afb816e96d0; Fri, 11 Jul 2025 19:07:01 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) Subject: Re: git: ba0d9b43e940 - main - kern_descrip.c: provide helpers to translate between fd flags namespace Message-Id: <3B0EC78E-DD18-4C78-BB72-F86F2E4E2193@yahoo.com> Date: Fri, 11 Jul 2025 12:06:50 -0700 To: John Baldwin , Konstantin Belousov , dev-commits-src-main@freebsd.org X-Mailer: Apple Mail (2.3826.600.51.1.1) References: <3B0EC78E-DD18-4C78-BB72-F86F2E4E2193.ref@yahoo.com> X-Spamd-Result: default: False [-0.58 / 15.00]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_SPAM_LONG(0.92)[0.917]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; MV_CASE(0.50)[]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; MIME_GOOD(-0.10)[text/plain]; NEURAL_SPAM_MEDIUM(0.01)[0.008]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_FROM(0.00)[yahoo.com]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCVD_COUNT_TWO(0.00)[2]; DKIM_TRACE(0.00)[yahoo.com:+]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.69.83:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[98.137.69.83:from]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; RCPT_COUNT_THREE(0.00)[3]; FROM_HAS_DN(0.00)[] X-Rspamd-Queue-Id: 4bf1Rf0QsQz3PXx X-Spamd-Bar: / John Baldwin wrote on Date: Fri, 11 Jul 2025 15:46:33 UTC : > On 7/8/25 17:49, Konstantin Belousov wrote: > > The branch main has been updated by kib: > >=20 > > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dba0d9b43e940077f4025e7e4e85d16c8= d525db79 > >=20 > > commit ba0d9b43e940077f4025e7e4e85d16c8d525db79 > > Author: Konstantin Belousov > > AuthorDate: 2025-07-08 16:30:29 +0000 > > Commit: Konstantin Belousov > > CommitDate: 2025-07-08 21:48:59 +0000 > >=20 > > kern_descrip.c: provide helpers to translate between fd flags = namespace > >=20 > > Reviewed by: markj > > Sponsored by: The FreeBSD Foundation > > Differential revision: https://reviews.freebsd.org/D51206 > > --- > > sys/kern/kern_descrip.c | 110 = +++++++++++++++++++++++++++++++++++++++--------- > > 1 file changed, 90 insertions(+), 20 deletions(-) > >=20 > > diff --git a/sys/kern/kern_descrip.c b/sys/kern/kern_descrip.c > > index 406236fc2723..2e1da2fdee29 100644 > > --- a/sys/kern/kern_descrip.c > > +++ b/sys/kern/kern_descrip.c > > @@ -480,6 +480,90 @@ kern_fcntl_freebsd(struct thread *td, int fd, = int cmd, intptr_t arg) > > return (error); > > } > . . . > > + > > +static uint8_t > > +open_to_fde_flags(int open_flags, bool sticky_orb) > > +{ > > + static const struct flags_trans_elem open_to_fde_flags_s[] =3D { > > + { .f =3D O_CLOEXEC, .t =3D UF_EXCLOSE }, > > + { .f =3D O_CLOFORK, .t =3D UF_FOCLOSE }, > > + { .f =3D O_RESOLVE_BENEATH, .t =3D UF_RESOLVE_BENEATH }, > > + }; > > + _Static_assert(open_to_fde_flags_s[nitems(open_to_fde_flags_s) - = 1].f =3D=3D > > + O_RESOLVE_BENEATH, "O_RESOLVE_BENEATH must be last, for = sticky_orb"); >=20 > This broke the GCC builds it seems. GCC doesn't think that it can = compute this > expression at compile time. >=20 > =46rom = https://ci.freebsd.org/job/FreeBSD-main-amd64-gcc14_build/1022/console: >=20 > 10:32:02 /workspace/src/sys/kern/kern_descrip.c: In function = 'open_to_fde_flags': > 10:32:02 /workspace/src/sys/kern/kern_descrip.c:560:79: error: = expression in static =3D > 10:32:02 assertion is not constant > 10:32:02 560 | = _Static_assert(open_to_fde_flags_s[nitems(open_to_fde_flags=3D > 10:32:02 _s) - 1].f =3D3D=3D3D In trying to figure this out, what I ran into was . . . QUOTE from: 6.6 Constant expressions (N3220 working draft) . . . The array-subscript [] and member-access -> operator, the address & and indirection * unary operators, and pointer casts may be used in the creation of an address constant, but the value of an object shall not be accessed by use of these operators. 119) . . . 119) Named constants or compound literal constants with arithmetic type, including names of constexpr objects, are valid in offset computations such as array subscripts or in points casts, as long as the expressions in which they occur form integer constant expressions. In contrast, names of other objects, even if const-qualified and with static storage duration, are not valid. END QUOTE It looks to me like gcc is avoiding allowing use of an extension to what the language definition provides as guarantees for what is a valid integer constant expression. =3D=3D=3D Mark Millard marklmi at yahoo.com