From owner-svn-src-head@freebsd.org Mon Jun 10 09:10:43 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BE99915B9C76; Mon, 10 Jun 2019 09:10:43 +0000 (UTC) (envelope-from tijl@freebsd.org) Received: from mailrelay102.isp.belgacom.be (mailrelay102.isp.belgacom.be [195.238.20.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "relay.skynet.be", Issuer "GlobalSign Organization Validation CA - SHA256 - G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D14FF6A666; Mon, 10 Jun 2019 09:10:42 +0000 (UTC) (envelope-from tijl@freebsd.org) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2CPAQDuHf5c/1H1sVtlGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAQGBZQKCD1kRUiASFBSNEIl2AQGCDDUBigiQHQkBAQIBAQE?= =?us-ascii?q?BASsMAQGEQAKCcCQ4EwEDAQEFAQEBAQRtHAxCAQwBhHsBBTocIxALDgYECSU?= =?us-ascii?q?PSAYBEoMjgg4LqBGEMgELAYRbgQoGgTQBi3OBf4QjPoREhWIElAiVHwmCEYZ?= =?us-ascii?q?EjHInlxuECokJhxORNSGBWE0wCIMnghsXiGGFQT0DMIIUjk4BAQ?= X-IPAS-Result: =?us-ascii?q?A2CPAQDuHf5c/1H1sVtlGQEBAQEBAQEBAQEBAQcBAQEBA?= =?us-ascii?q?QGBZQKCD1kRUiASFBSNEIl2AQGCDDUBigiQHQkBAQIBAQEBASsMAQGEQAKCc?= =?us-ascii?q?CQ4EwEDAQEFAQEBAQRtHAxCAQwBhHsBBTocIxALDgYECSUPSAYBEoMjgg4Lq?= =?us-ascii?q?BGEMgELAYRbgQoGgTQBi3OBf4QjPoREhWIElAiVHwmCEYZEjHInlxuECokJh?= =?us-ascii?q?xORNSGBWE0wCIMnghsXiGGFQT0DMIIUjk4BAQ?= Received: from 81.245-177-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.177.245.81]) by relay.skynet.be with ESMTP; 10 Jun 2019 11:09:10 +0200 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.15.2/8.15.2) with ESMTP id x5A9996m007510; Mon, 10 Jun 2019 11:09:09 +0200 (CEST) (envelope-from tijl@FreeBSD.org) Date: Mon, 10 Jun 2019 11:09:09 +0200 From: =?UTF-8?B?VMSzbA==?= Coosemans To: Dmitry Chagin , glebius@FreeBSD.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r348847 - head/sys/sys Message-ID: <20190610110909.3e6fbc13@kalimero.tijl.coosemans.org> In-Reply-To: <201906100528.x5A5S4gm072561@repo.freebsd.org> References: <201906100528.x5A5S4gm072561@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D14FF6A666 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.98)[-0.983,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jun 2019 09:10:43 -0000 On Mon, 10 Jun 2019 05:28:04 +0000 (UTC) Dmitry Chagin wrote: > Author: dchagin > Date: Mon Jun 10 05:28:03 2019 > New Revision: 348847 > URL: https://svnweb.freebsd.org/changeset/base/348847 > > Log: > Use C11 anonymous unions. > > PR: 215202 > Reported by: glebius > MFC after: 2 weeks > > Modified: > head/sys/sys/ucred.h > > Modified: head/sys/sys/ucred.h > ============================================================================== > --- head/sys/sys/ucred.h Mon Jun 10 05:09:34 2019 (r348846) > +++ head/sys/sys/ucred.h Mon Jun 10 05:28:03 2019 (r348847) > @@ -89,12 +89,11 @@ struct xucred { > gid_t cr_groups[XU_NGROUPS]; /* groups */ > union { > void *_cr_unused1; /* compatibility with old ucred */ > - pid_t _pid; > - } _cr; > + pid_t cr_pid; > + }; > }; > #define XUCRED_VERSION 0 > > -#define cr_pid _cr._pid > /* This can be used for both ucred and xucred structures. */ > #define cr_gid cr_groups[0] Isn't this a userland header that should work with non-C11 compilers?