Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 18 Sep 2012 08:45:36 -0700
From:      John-Mark Gurney <jmg@funkthat.com>
To:        Chris Rees <utisoft@gmail.com>
Cc:        freebsd-rc@freebsd.org
Subject:   Re: minor patch to defaults/rc.conf
Message-ID:  <20120918154536.GD58312@funkthat.com>
In-Reply-To: <CADLo83_zk6fNzyb98=XoCSamPxfVkqNUhpZmfQT-kyrEBBvmvw@mail.gmail.com>
References:  <20120918152743.GC58312@funkthat.com> <CADLo83_zk6fNzyb98=XoCSamPxfVkqNUhpZmfQT-kyrEBBvmvw@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Chris Rees wrote this message on Tue, Sep 18, 2012 at 16:37 +0100:
> On 18 Sep 2012 16:28, "John-Mark Gurney" <jmg@funkthat.com> wrote:
> >
> > Any objections?
> >
> > This makes it explicate that these controls are dependant upon AC
> > online/offline state...
> 
> Patch?

Ugh, sorry:
Index: etc/defaults/rc.conf
===================================================================
--- etc/defaults/rc.conf	(revision 240566)
+++ etc/defaults/rc.conf	(working copy)
@@ -654,10 +654,10 @@
 devfs_set_rulesets=""	# A list of /mount/dev=ruleset_name settings to
 			# apply (must be mounted already, i.e. fstab(5))
 devfs_load_rulesets="NO"	# Enable to always load the default rulesets
-performance_cx_lowest="HIGH"	# Online CPU idle state
-performance_cpu_freq="NONE"	# Online CPU frequency
-economy_cx_lowest="HIGH"	# Offline CPU idle state
-economy_cpu_freq="NONE"		# Offline CPU frequency
+performance_cx_lowest="HIGH"	# AC Online CPU idle state
+performance_cpu_freq="NONE"	# AC Online CPU frequency
+economy_cx_lowest="HIGH"	# AC Offline CPU idle state
+economy_cpu_freq="NONE"		# AC Offline CPU frequency
 virecover_enable="YES"	# Perform housekeeping for the vi(1) editor
 ugidfw_enable="NO"	# Load mac_bsdextended(4) rules on boot
 bsdextended_script="/etc/rc.bsdextended"	# Default mac_bsdextended(4)

Also, I noticed that when changing economy_cx_lowest, the indentation
of the comment changed, should I add a couple spaces after the closing
quote to keep the comment aligned?

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120918154536.GD58312>