From owner-freebsd-usb@FreeBSD.ORG Sun Jan 14 20:10:17 2007 Return-Path: X-Original-To: freebsd-usb@hub.freebsd.org Delivered-To: freebsd-usb@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8880816A412 for ; Sun, 14 Jan 2007 20:10:17 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 46E7613C45A for ; Sun, 14 Jan 2007 20:10:17 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l0EKAGZn062356 for ; Sun, 14 Jan 2007 20:10:16 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l0EKAGqG062355; Sun, 14 Jan 2007 20:10:16 GMT (envelope-from gnats) Resent-Date: Sun, 14 Jan 2007 20:10:16 GMT Resent-Message-Id: <200701142010.l0EKAGqG062355@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-usb@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Julian Stacey Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CA04E16A407 for ; Sun, 14 Jan 2007 20:08:37 +0000 (UTC) (envelope-from jhs@flat.berklix.net) Received: from thin.berklix.org (thin.berklix.org [194.246.123.68]) by mx1.freebsd.org (Postfix) with ESMTP id 58E3D13C45A for ; Sun, 14 Jan 2007 20:08:36 +0000 (UTC) (envelope-from jhs@flat.berklix.net) Received: from js.berklix.net (p549A5D5E.dip.t-dialin.net [84.154.93.94]) (authenticated bits=128) by thin.berklix.org (8.12.11/8.12.11) with ESMTP id l0EK8Wfn057853; Sun, 14 Jan 2007 21:08:33 +0100 (CET) (envelope-from jhs@flat.berklix.net) Received: from fire.jhs.private (fire.jhs.private [192.168.91.41]) by js.berklix.net (8.13.6/8.13.6) with ESMTP id l0EK8UEt008360; Sun, 14 Jan 2007 21:08:31 +0100 (CET) (envelope-from jhs@flat.berklix.net) Received: from fire.jhs.private (localhost.jhs.private [127.0.0.1]) by fire.jhs.private (8.13.6/8.13.6) with ESMTP id l0EK8UDq048975; Sun, 14 Jan 2007 21:08:30 +0100 (CET) (envelope-from jhs@fire.jhs.private) Received: (from jhs@localhost) by fire.jhs.private (8.13.6/8.13.6/Submit) id l0EK8U7c048974; Sun, 14 Jan 2007 21:08:30 +0100 (CET) (envelope-from jhs) Message-Id: <200701142008.l0EK8U7c048974@fire.jhs.private> Date: Sun, 14 Jan 2007 21:08:30 +0100 (CET) From: Julian Stacey To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Bernd Walter , Julian Stacey , Atom Smasher Subject: usb/107924: usbd does not call detach X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Julian Stacey List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jan 2007 20:10:17 -0000 >Number: 107924 >Category: usb >Synopsis: usbd does not call detach >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-usb >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Jan 14 20:10:15 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Julian Stacey >Release: FreeBSD 6.2-RELEASE i386 >Organization: hrrp://berklix.com >Environment: System: FreeBSD fire.jhs.private 6.2-RELEASE FreeBSD 6.2-RELEASE #0: Mon Dec 11 15:29:22 CET 2006 jhs@fire.jhs.private:/usr2/release/6.1-RELEASE/src/sys/i386/compile/FIRE32.small i386 >Description: usbd does not call detach >How-To-Repeat: Atom Smasher reported it. Julian Stacey verified it in practice & read the code to verify it doesnt get called, commented in patch below Bernd Walter wrote: usbd is depricated, use devd instead. >Fix: Apply patch created bt diff -c storedd in http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.sbin/usbd/ to document the deficiency & work round. *** usbd.8.o Sun Jan 14 20:48:31 2007 --- usbd.8 Sun Jan 14 20:52:06 2007 *************** *** 130,138 **** --- 130,141 ---- .It Pa /dev/usb1 .It etc . .El + .Sh BUGS + Detach does not work. Use Devd if you need to call a script on detach. .Sh SEE ALSO .Xr usb 4 , .Xr usbd.conf 5 + .Xr devd 8 .Sh HISTORY The .Nm The error is still there in 6-Stable too. There is no src/usr.sbin/usbd/usbd.c in current. I don't know the code, & too tired & busy to fix this, Someone else here able to fix it & post a patch ? If not, Atom Smasher please use dmesg send-pr to report this identified bug. *** 6.1-RELEASE/src/usr.sbin/usbd/usbd.c Fri Jul 1 17:49:52 2005 --- new-generic/src/usr.sbin/usbd/usbd.c Wed Jan 10 01:54:54 2007 *************** *** 879,886 **** --- 879,891 ---- devinfo = &events.u.ue_device; for (i = 0; i < USB_MAX_DEVNAMES; i++) { + printf(" \nJHS1\n" ); if (devinfo->udi_devnames[i][0] == '\0') break; + /* This break is a problem it prevents + USB_EVENT_IS_DETACH being run at JHS3 + */ + printf(" \nJHS2\n" ); memcpy(&the_event, &events, sizeof(the_event)); the_devinfo = &the_event.u.ue_device; *************** *** 925,930 **** --- 930,936 ---- if (USB_EVENT_IS_ATTACH(the_event.ue_type) && action_match.action->attach) execute_command(action_match.action->attach); + printf(" \nJHS3\n" ); if (USB_EVENT_IS_DETACH(the_event.ue_type) && action_match.action->detach) execute_command(action_match.action->detach); >Release-Note: >Audit-Trail: >Unformatted: