From owner-freebsd-acpi@FreeBSD.ORG  Tue Mar 30 09:05:47 2010
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
Delivered-To: freebsd-acpi@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8FA9D106564A
	for <freebsd-acpi@freebsd.org>; Tue, 30 Mar 2010 09:05:47 +0000 (UTC)
	(envelope-from dan@obluda.cz)
Received: from smtp1.kolej.mff.cuni.cz (smtp1.kolej.mff.cuni.cz
	[78.128.192.10])
	by mx1.freebsd.org (Postfix) with ESMTP id 291B28FC15
	for <freebsd-acpi@freebsd.org>; Tue, 30 Mar 2010 09:05:46 +0000 (UTC)
X-Envelope-From: dan@obluda.cz
Received: from kgw.obluda.cz (kgw.obluda.cz [193.179.199.50])
	by smtp1.kolej.mff.cuni.cz (8.14.3/8.14.3) with ESMTP id o2U95i7v007190;
	Tue, 30 Mar 2010 11:05:45 +0200 (CEST) (envelope-from dan@obluda.cz)
Message-ID: <4BB1BEE8.8070505@obluda.cz>
Date: Tue, 30 Mar 2010 11:05:44 +0200
From: Dan Lukes <dan@obluda.cz>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US;
	rv:1.9.1.8) Gecko/20100221 SeaMonkey/2.0.3
MIME-Version: 1.0
To: Rui Paulo <rpaulo@freebsd.org>
References: <4BB170E7.3030407@obluda.cz>
	<8D820BAA-C1B9-408C-AAF3-EA69612D2C46@freebsd.org>
In-Reply-To: <8D820BAA-C1B9-408C-AAF3-EA69612D2C46@freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-acpi@freebsd.org
Subject: Re: Brightness change on notebook that follow ACPI specification
 (par. B.7)
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Mar 2010 09:05:47 -0000

On 03/30/10 10:47, Rui Paulo:
>> Most notebooks have special keys (mostly Fn+something) to change brightness of LCD display.
>> Some of them (my notebok, for example) follows the ACPI specification (paragraph B.7) how to announce the user request for brightness change to OS.
>> I implemented such handling as part of acpi-video module.

> I see nothing wrong with this patch and I think it can be committed, but I would like others to take a look.

Thanks. Code review needs to be done also, but it would be nice to have 
more "yes, it works with my NB and OS ?.??" reports at this phase ...

Did you tried it ? Which notebook and FreeBSD version ?

						Dan