From owner-svn-src-all@freebsd.org Sat Oct 31 12:14:35 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 751CA44AF29; Sat, 31 Oct 2020 12:14:35 +0000 (UTC) (envelope-from se@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CNdQg2Slwz4QGB; Sat, 31 Oct 2020 12:14:35 +0000 (UTC) (envelope-from se@freebsd.org) Received: from Stefans-MBP-WLAN.fritz.box (p200300cd5f0bbc00041f9800b152abd1.dip0.t-ipconnect.de [IPv6:2003:cd:5f0b:bc00:41f:9800:b152:abd1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id AF81918E3D; Sat, 31 Oct 2020 12:14:34 +0000 (UTC) (envelope-from se@freebsd.org) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202010311144.09VBiBbh063210@repo.freebsd.org> From: Stefan Esser Subject: Re: svn commit: r367196 - head/lib/libc/gen Message-ID: Date: Sat, 31 Oct 2020 13:14:33 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ssSGJEIwFEAn0ESPDRlKBbblrGriSQhgO" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Oct 2020 12:14:35 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ssSGJEIwFEAn0ESPDRlKBbblrGriSQhgO Content-Type: multipart/mixed; boundary="0VX0hvZpHEDLx27FpKmtaGqjxpvZcEXh8"; protected-headers="v1" From: Stefan Esser To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: Subject: Re: svn commit: r367196 - head/lib/libc/gen References: <202010311144.09VBiBbh063210@repo.freebsd.org> In-Reply-To: --0VX0hvZpHEDLx27FpKmtaGqjxpvZcEXh8 Content-Type: multipart/mixed; boundary="------------41238D8B78E053E11E01C409" Content-Language: en-US This is a multi-part message in MIME format. --------------41238D8B78E053E11E01C409 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Sorry for the bad bug that I introduced with this attempted style fix! The correct code has been committed as r367199. Am 31.10.20 um 12:46 schrieb xtouqh@hotmail.com: > Stefan E=C3=9Fer wrote: >> Author: se >> Date: Sat Oct 31 11:44:10 2020 >> New Revision: 367196 >> URL: https://svnweb.freebsd.org/changeset/base/367196 >> >> Log: >> =C2=A0=C2=A0 Fix style, no functional change >> =C2=A0=C2=A0 Submitted by:=C2=A0=C2=A0=C2=A0 kib >> =C2=A0=C2=A0 MFC after:=C2=A0=C2=A0=C2=A0 3 days >> >> Modified: >> =C2=A0=C2=A0 head/lib/libc/gen/sysctl.c >> >> Modified: head/lib/libc/gen/sysctl.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=20 >> >> --- head/lib/libc/gen/sysctl.c=C2=A0=C2=A0=C2=A0 Sat Oct 31 03:36:31 2= 020=C2=A0=C2=A0=C2=A0 (r367195) >> +++ head/lib/libc/gen/sysctl.c=C2=A0=C2=A0=C2=A0 Sat Oct 31 11:44:10 2= 020=C2=A0=C2=A0=C2=A0 (r367196) >> @@ -79,23 +79,23 @@ sysctl(const int *name, u_int namelen, void *oldp,= =20 >> siz >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 switch (name[1]) { >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 case USER_CS_PATH: >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (oldp && orig_oldlen < = sizeof(_PATH_STDPATH)) { >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (oldp =3D=3D NULL && or= ig_oldlen < sizeof(_PATH_STDPATH)) { >=20 > These checks are not identical, should not the new one be !=3D NULL? >=20 >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 errno =3D ENOMEM; >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 re= turn -1; >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 re= turn (-1); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 *oldlenp =3D si= zeof(_PATH_STDPATH); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (oldp !=3D N= ULL) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 memmove(oldp, _PATH_STDPATH, sizeof(_PATH_STDPATH)); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return (0); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 case USER_LOCALBASE: >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (oldp && orig_oldlen < = sizeof(_PATH_LOCALBASE)) { >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (oldp =3D=3D NULL && or= ig_oldlen < sizeof(_PATH_LOCALBASE)) { >=20 > Same here. >=20 >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 errno =3D ENOMEM; >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 re= turn -1; >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 re= turn (-1); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 *oldlenp =3D si= zeof(_PATH_LOCALBASE); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (oldp !=3D N= ULL) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 memmove(oldp, _PATH_LOCALBASE, sizeof(_PATH_LOCALBASE)); >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return(0); >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return (0); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (oldp && *oldlenp < sizeof(int)) { >=20 --------------41238D8B78E053E11E01C409-- --0VX0hvZpHEDLx27FpKmtaGqjxpvZcEXh8-- --ssSGJEIwFEAn0ESPDRlKBbblrGriSQhgO Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAl+dVSkFAwAAAAAACgkQR+u171r99USK DQf/YTlx8AqjmP/WUYFMVpbXzQv3Ee5mGGJnnqnmp8twKFTZH3O8aXOS/oTuVgVyaHL6qxFtzbW6 A+FrP3ckfwRVZRr0uwF4/gMeyQn00bRGDxUTY3YPFTr+245TZmseHOeuVJsafx8HoynVWvpc4Clv x+M1sAE8LuOWc/e4CeL6/IBH+6FegxfnOY1EXWfvN6uq1x90wQbi9T3xD9ovsVYa3mUnFhqnu7tu ZA/bnIz6n3+FMGVh0QY3Bu5F2RtgMYXyfKcK4rAb/XK1c9UPMqmrCIga/GORBYwTQ9bkhOOKJbWv 1f7Uav0nQynsDoqCRhZRkgo5lgyfYCARCLS7xcMr0A== =4BxE -----END PGP SIGNATURE----- --ssSGJEIwFEAn0ESPDRlKBbblrGriSQhgO--