Date: Mon, 02 Apr 2007 23:39:42 -0700 From: Julian Elischer <julian@elischer.org> To: JoaoBR <joao@matik.com.br> Cc: julian@freebsd.org, freebsd-stable@freebsd.org Subject: Re: ipfw add pipe broken? Message-ID: <4611F6AE.1010006@elischer.org> In-Reply-To: <200704011557.20518.joao@matik.com.br> References: <200704011107.22750.joao@matik.com.br> <200704011255.49740.joao@matik.com.br> <200704011824.l31IOi46036471@lava.sentex.ca> <200704011557.20518.joao@matik.com.br>
next in thread | previous in thread | raw e-mail | index | archive | help
JoaoBR wrote:
> On Sunday 01 April 2007 15:22, Mike Tancsa wrote:
>> At 11:55 AM 4/1/2007, JoaoBR wrote:
>>> by all respect to Julians work but with ipfw broken and sunday fucked up
>>> ...
>>>
>>> kind of scaring when seeing "I have no time to check, I do it on tuesday"
>>> or "I need to do the userland ipfw too to add some new features, but, not
>>> today.."
>>> please do it all or don't do it, ipfw is an mature and essential
>>> part where we
>>> do not espect such sudden surprises in releng6 to happen
>> I seriously doubt he intentionally meant to break it.... Accidents
>
> man sure not, no one said that
I thought I had these MFC's all worked out and one seems to have some how been
mixed up in the testing.
Unfortunately the timing really sucked as I was just heading out
when I found that out and I didn't have time to figure out exactly what
went wrong in the MFC. I just backed out what appeared to be the problem commit.
turns out there was another part of it.
This is the missing change that was buried on another commit.
Apparently, the following is also needed, to revert correctly.
--- src/sys/netinet/ip_fw2.c.orig Mon Apr 2 11:48:03 2007
+++ src/sys/netinet/ip_fw2.c Mon Nov 20 18:19:10 2006
@@ -3861,7 +3836,7 @@
case O_PIPE:
case O_QUEUE:
- if (cmdlen != F_INSN_SIZE(ipfw_insn))
+ if (cmdlen != F_INSN_SIZE(ipfw_insn_pipe))
goto bad_size;
goto check_action;
I'll commit this and then forward change the MFC again as soon as I find out where
the ball was dropped in the MFC testing.
>
>> happen. Roll your sources back to Friday and you will be OK until
>
> yaya
>
> but essential and especially mature code should be tested before comitting
> changes I guess, I believe that ipfw wasn't tested before beeing hacked and
> comitted this time, and overall btw, there was an alert and reply to the
> commit msg on cvs which then was politly ignored "until tuesday" ... luck
> that it wasn't the bootstrap or something
>
>> its sorted out. Remember, its a best effort, not perfect effort project.
>
> sure, but when became perfect the honor is welcome as it comes for free when
> it went wrong ;)
>
>> ---Mike
>>
>>
>
> Joćo
>
>
>
>
>
>
>
> A mensagem foi scaneada pelo sistema de e-mail e pode ser considerada segura.
> Service fornecido pelo Datacenter Matik https://datacenter.matik.com.br
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4611F6AE.1010006>