From owner-freebsd-arm@FreeBSD.ORG Fri Jan 23 21:21:14 2015 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 90A066A5 for ; Fri, 23 Jan 2015 21:21:14 +0000 (UTC) Received: from mail-pd0-f181.google.com (mail-pd0-f181.google.com [209.85.192.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 62039363 for ; Fri, 23 Jan 2015 21:21:14 +0000 (UTC) Received: by mail-pd0-f181.google.com with SMTP id g10so8314602pdj.12 for ; Fri, 23 Jan 2015 13:21:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=F0GbpQU/Ox/mX8RF2zwTZBPhS6He1Etu3+6XYGUWTuE=; b=gwYwYZ8EdeHOtXphhxlMNTuZoR5c8dOJrZ+/Z6KLMWupX+jB8aZgHQRhOBAebBjoo9 pW49J6gyho0LpVVoQ0w+PRVFssW80ZZAauRZTAGMUUoKAxlpe3mbv2BNzxKwGieH40+b HObG3ykYEeNc6DQbBM75sOBbA26IDBR2F21XOZVuStFxGX37Il5WxnKU22uIAOFaBKwp c3iT2cZeE77shLYR82xAVmNUenjiIFgxMPnvwV6808RYRe3LJpuMxRvNu65Bxeq4aXI1 e3fX7JMRlC35AR99ZdYMIv0AAXqFduUdvhP6mfeIbnT+tBxlCKSzozHjyz8Ap8r8eIz+ 0tAQ== X-Gm-Message-State: ALoCoQnkMPQ61/lFTuYAyUO+RYIOfXv3i+hGS0qlUnQZVF2Gi8KwhDaZvT1VUeegHnvgT6tsLfRX X-Received: by 10.70.101.69 with SMTP id fe5mr14614731pdb.150.1422048066807; Fri, 23 Jan 2015 13:21:06 -0800 (PST) Received: from bsdimp.corp.netflix.com ([69.53.237.72]) by mx.google.com with ESMTPSA id ni9sm2838978pdb.36.2015.01.23.13.21.05 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 23 Jan 2015 13:21:05 -0800 (PST) Sender: Warner Losh Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) Subject: Re: mount_smbfs From: Warner Losh In-Reply-To: <20150123195403.GO1949@funkthat.com> Date: Fri, 23 Jan 2015 13:21:05 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: <54B9DCD1.3040306@foxvalley.net> <4759EAA0-D4AA-4923-9350-B7E753819169@me.com> <6E32991C3BD8465DB8DB0E65DFDA47AA@ad.peach.ne.jp> <20150123195403.GO1949@funkthat.com> To: John-Mark Gurney X-Mailer: Apple Mail (2.1993) Cc: freebsd-arm , Rui Paulo X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jan 2015 21:21:14 -0000 > On Jan 23, 2015, at 11:54 AM, John-Mark Gurney = wrote: >=20 > Daisuke Aoyama wrote this message on Sat, Jan 24, 2015 at 03:07 +0900: >> Quick hack patch is attached. >=20 > Please use {l,b}e16dec, or if the code is suppose to be native endian, > make it dependant on __NO_STRICT_ALIGNMENT and add the proper endian > swap, not __arm__ as there are other arches that require the same = fix... If there=E2=80=99s just a couple of places that need this, don=E2=80=99t = bother making them dependent on __NO_STRICT_ALIGNMENT. That clutters things up a bit too much. Given = the 3 or 4 places this is used, and the relative infrequency of the calls, = just doing a memcpy unconditionally is always correct and reduces the risk of one branch of = the #if being changed w/o the other. Since it is already using NBENCODE(), I think = that using {l,b}e16enc (not dec) would be a larger code churn. Warner