From owner-svn-ports-all@FreeBSD.ORG Wed Sep 5 21:21:54 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 38B1E1065670; Wed, 5 Sep 2012 21:21:54 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 24DEF8FC16; Wed, 5 Sep 2012 21:21:52 +0000 (UTC) Received: by bkcje9 with SMTP id je9so523376bkc.13 for ; Wed, 05 Sep 2012 14:21:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=rSH/To/feJYm931tARjKzsyyPf3cSUlSh9xJt1s8WYI=; b=cyJNNkYnZWB5mJnramtvG9OFinBOl3BtWWW9Sa4T13m5535uR5vqfKKj0bTE9ZpbnB 227e337q9VgtGmKT4qSIm5nLv4qsTJo4qa2NeMd/hXC3j2GxhMpLErlFz3MjMu2Xce5p OL2xkVoWwfuPCcANLK/sKIDqzEpKQpIJpyD3O4o/etYMFDRLV8v4i79Ipyg2f35GgcVn 0yelUAkRhWAL8fVQz2Mye6YLqVb3e6oIWl0QE0abWoGzUfhFufLS12EYKz/LqqelLFvj QjdXt/4Wn4NJrrekfbHPhw0BtHWXMuBdnKZoH1kNEjOQ0MBDzaoKYYbZEQ5+P2gzoQNN noKA== Received: by 10.204.10.70 with SMTP id o6mr9841450bko.31.1346880111978; Wed, 05 Sep 2012 14:21:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.10.141 with HTTP; Wed, 5 Sep 2012 14:21:20 -0700 (PDT) In-Reply-To: <5047BF93.2060704@FreeBSD.org> References: <201209032233.q83MXSa2053725@svn.freebsd.org> <50453146.2080707@smeets.im> <504537D2.5050608@FreeBSD.org> <50454279.4020309@smeets.im> <50457770.4060402@FreeBSD.org> <5045E904.5080608@smeets.im> <50462DEC.3040202@FreeBSD.org> <5047B7A6.8040601@smeets.im> <5047BC0D.1000707@FreeBSD.org> <5047BF93.2060704@FreeBSD.org> From: Chris Rees Date: Wed, 5 Sep 2012 22:21:20 +0100 Message-ID: To: Doug Barton Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Florian Smeets , ports-committers@freebsd.org Subject: Re: svn commit: r303626 - head/www/xpi-firebug X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Sep 2012 21:21:54 -0000 On 5 September 2012 22:09, Doug Barton wrote: > On 09/05/2012 14:01, Chris Rees wrote: >> >> On 5 Sep 2012 21:54, "Doug Barton" > > wrote: >>> >>> -----BEGIN PGP SIGNED MESSAGE----- >>> Hash: SHA256 >>> >>> On 09/05/2012 13:35, Florian Smeets wrote: >>> > On 04.09.12 18:35, Doug Barton wrote: >>> >>> >> Portmaster, and other tools, use this method extensively to read >>> >> those files, and this issue causes those tools to break while >>> >> processing those files. >>> >> >>> > >>> > You keep repeating this, without proof. >>> >>> Um, what kind of proof do you need? I wrote the code, I know how it >>> works, and I know that the parts of it that use "while read" to >>> process distinfo files breaks because of this issue. There have also >>> been other people who have raised this issue, as relates to their tools. >>> >>> I also showed you how to reproduce it yourself. >>> >>> How much more proof do you need? >> >> I think Florian is asking for a real example, perhaps a portmaster command; >> >> % portmaster reproduce-this-error > > If Florian isn't interested in taking my word for it, he can look > through the code and find ways to reproduce it himself. :) Well, since you provoked me into it, I've had a look, the main distinfo part I've distilled into something simpler: [crees@pegasus]~% svn co $ports/head/www/xpi-firebug@r303627 A xpi-firebug/distinfo A xpi-firebug/pkg-descr A xpi-firebug/pkg-plist A xpi-firebug/Makefile Checked out revision 303627. [crees@pegasus]~% cd xpi-firebug [crees@pegasus]~/xpi-firebug% echo $s while> done SHA256 [crees@pegasus]~/xpi-firebug% Granted, that leaves off the SIZE line, but I can't see any problems here... The only part of portmaster that I can see that cares about SIZE depends on ports/106483, which is still in waiting (is this going to be needed with pkgng anyway?) Given this... specifics could be nice for people who can't distil the actual problem. I understand that this is correct, but you can't claim it affects portmaster when it actually doesn't. Chris