From owner-freebsd-current  Tue Mar  6  8:24:40 2001
Delivered-To: freebsd-current@freebsd.org
Received: from blizzard.sabbo.net (smtp.sabbo.net [193.193.218.18])
	by hub.freebsd.org (Postfix) with ESMTP
	id C140B37B71A; Tue,  6 Mar 2001 08:23:54 -0800 (PST)
	(envelope-from sobomax@FreeBSD.org)
Received: from vic.sabbo.net (root@vic.sabbo.net [193.193.218.112])
	by blizzard.sabbo.net (8.10.1/8.10.1) with ESMTP id f26GNYM25389;
	Tue, 6 Mar 2001 18:23:37 +0200
Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1])
	by vic.sabbo.net (8.11.2/8.11.2) with ESMTP id f26GNhG50898;
	Tue, 6 Mar 2001 18:23:43 +0200 (EET)
	(envelope-from sobomax@FreeBSD.org)
Message-ID: <3AA50F01.6560C34A@FreeBSD.org>
Date: Tue, 06 Mar 2001 18:23:29 +0200
From: Maxim Sobolev <sobomax@FreeBSD.org>
Organization: Vega International Capital
X-Mailer: Mozilla 4.76 [en] (WinNT; U)
X-Accept-Language: uk,ru,en
MIME-Version: 1.0
To: Warner Losh <imp@harmony.village.org>
Cc: igorr@crosswinds.net, freebsd-current@FreeBSD.org,
	phk@FreeBSD.org
Subject: Re: Correct size of kinfo_proc
References: <20010228161009.B14235@linux.rainbow>  <3A9CF680.563D9F2B@FreeBSD.org> <200103010440.f214e1d45348@harmony.village.org>
Content-Type: text/plain; charset=koi8-r
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Warner Losh wrote:

> In message <20010228161009.B14235@linux.rainbow> Igor Robul writes:
> : On Wed, Feb 28, 2001 at 03:00:48PM +0200, Maxim Sobolev wrote:
> : > Hi Poul,
> : >
> : > In revision 1.31 of src/sys/sys/user.h you have added new ki_layout field to
> : > kinfo_proc structure, but forgot to increase KINFO_PROC_SIZE  from 644 to 648.
> : > Please correct.
> : Why don't use sizeof() insead of hardcoding numbers?
>
> Because KINFO_PROC_SIZE is part of the ABI.  Changes to its size are
> always wrong, in that they break the ABI.  The checks are there to
> tell us when the ABI has been broken.

Well, we are now well informed about this, could we just fix sys/sys/user.h to match
relity (credit goes to phk for broking it and ignoring my posts completely)?

max@notebook$ dmesg | grep WARNING
WARNING: size of kinfo_proc (648) should be 644!!!
max@notebook$ uname -a
FreeBSD notebook 5.0-CURRENT FreeBSD 5.0-CURRENT #2: Tue Mar  6 15:34:23 EET 2001
root@notebook:/usr/src/sys/compile/NOTEBOOK  i386


-Maxim


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message