From owner-svn-ports-head@freebsd.org Wed Oct 24 13:29:17 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E4349FD8219; Wed, 24 Oct 2018 13:29:16 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 886048CD52; Wed, 24 Oct 2018 13:29:16 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 1121D2203E; Wed, 24 Oct 2018 09:29:16 -0400 (EDT) Received: from web3 ([10.202.2.213]) by compute4.internal (MEProxy); Wed, 24 Oct 2018 09:29:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=o2FyZlQ/SYq3NWxhi5eEK6VLAbRFNfts24uctCLST pI=; b=vzifg5pvAEBlikXsGsed3YeAxMPTdQWfwnobKdC/PIV6/9f+XtLr6fjJR 1nEic+MmjeaRJ7nxhV00mX7udUKVYbQNwQ9Gp76oozBRaymuQENgKLY9ZIH3UYBG VosrbYgopCRBDwZeeRU1XQbO2W0LpLp6evYPCc5kNz47JFwjDXrqUsDfD7yAcfXo Sx79GzbhSGNN+WHgPpXVSricFugVZjXBgEwgtk71tBnTCfs2+HH+BtJJ0si4Yc78 Th4D8gZoA92xMLQL9Q9sQ69F8y6mid8RPdWltpq3ZT7+rfxEHxzJIVfgJmaYj19d QmN8mHysbPdH/yiyXIHyIt00vIadA== X-ME-Sender: X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 99) id BDF1E9E50C; Wed, 24 Oct 2018 09:29:15 -0400 (EDT) Message-Id: <1540387755.2428664.1553012856.09F07AB9@webmail.messagingengine.com> From: Tobias Kortkamp To: Wen Heping , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-b315a288 In-Reply-To: <201810241148.w9OBmdaA018563@repo.freebsd.org> References: <201810241148.w9OBmdaA018563@repo.freebsd.org> Subject: Re: svn commit: r482903 - head/chinese/fcitx-libpinyin Date: Wed, 24 Oct 2018 15:29:15 +0200 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2018 13:29:17 -0000 On Wed, Oct 24, 2018, at 13:48, Wen Heping wrote: > Author: wen > Date: Wed Oct 24 11:48:38 2018 > New Revision: 482903 > URL: https://svnweb.freebsd.org/changeset/ports/482903 > > Log: > - Update to 0.5.3 > > PR: 231616 > Submitted by: ryo@tetera.org > Approved by: maintainer > > Modified: > head/chinese/fcitx-libpinyin/Makefile > head/chinese/fcitx-libpinyin/distinfo > head/chinese/fcitx-libpinyin/pkg-plist > > Modified: head/chinese/fcitx-libpinyin/Makefile > ============================================================================== > --- head/chinese/fcitx-libpinyin/Makefile Wed Oct 24 11:47:28 2018 (r482902) > +++ head/chinese/fcitx-libpinyin/Makefile Wed Oct 24 11:48:38 2018 (r482903) > @@ -2,7 +2,7 @@ > # $FreeBSD$ > > PORTNAME= fcitx-libpinyin > -PORTVERSION= 0.3.2 > +PORTVERSION= 0.5.3 > CATEGORIES= chinese > MASTER_SITES= http://download.fcitx-im.org/${PORTNAME}/:body \ > http://download.fcitx-im.org/data/:data > @@ -16,28 +16,30 @@ COMMENT= Libpinyin support for Fcitx > > LICENSE= GPLv2 > > +BUILD_DEPENDS= bash:shells/bash > LIB_DEPENDS= libfcitx-config.so:chinese/fcitx \ > - libpinyin.so:chinese/libpinyin > + libpinyin.so:chinese/libpinyin\ > + libFcitxQt5WidgetsAddons.so:textproc/fcitx-qt5 > > USES= tar:xz cmake gettext pkgconfig > INSTALLS_ICONS= yes > > -_MODEL_VER= 20130308 > +_MODEL_VER= 20161206 > > -OPTIONS_DEFINE= QT4 > -OPTIONS_DEFAULT=QT4 > -QT4_DESC= Enable Qt4 for dictmanager > +OPTIONS_DEFINE= QT5 > +OPTIONS_DEFAULT=QT5 > +QT5_DESC= Enable Qtr for dictmanager > > .include > > -.if ${PORT_OPTIONS:MQT4} > -USES+= qt:4 > -USE_QT= qmake_build moc_build rcc_build uic_build gui webkit > +.if ${PORT_OPTIONS:MQT5} > +USES+= qt:5 > +USE_QT= qmake_build gui webengine webkit buildtools > USE_LDCONFIG= ${PREFIX}/lib/fcitx/qt - Why not use options helpers here? - Are you sure that qt5-buildtools is a run dependency or was buildtools_build meant here? - It is unusual for a port to depend on both qt5-webengine and qt5-webkit. I find no reference to webkit in the sources. Can you recheck Poudriere logs if it really links with libQt5WebKit?