From owner-svn-src-head@freebsd.org Fri Dec 6 20:10:09 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5C5AF1B4E08; Fri, 6 Dec 2019 20:10:09 +0000 (UTC) (envelope-from loos.br@gmail.com) Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47V3bj1qt7z3LYw; Fri, 6 Dec 2019 20:10:09 +0000 (UTC) (envelope-from loos.br@gmail.com) Received: by mail-io1-xd42.google.com with SMTP id x1so8575484iop.7; Fri, 06 Dec 2019 12:10:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=40xzA7/CCtF2ieDGz/5A6zTdi4pEKj1ctuSk4L11Ksw=; b=l+1FdMFoftdZCUjvq6WEks7UWD8u3p8bLwXg9kH0nplkxNZWsPCdQhn97vpVed5s/N BBzP3NUpI8lCffiQb8mCgO12qVuVeDI1vukTB8NNj0JfDW+Yfk3PNw0yjaAMVE1H+oGm yahDKyGrG3YA1SoCpPM4xZN1Wt2Wf3pSHNAiFpWILKI3f6E9a7Qk1GzMM7dn7HK4CDB6 sWCXBfMQ0lXOTllv8Nfr+j7rXYQ8J6ThJab+chRlWcvrF85rNcO9BoW+xJ3SpnETIGcp D9r6QBlMDImcPLZhn9lQIHMNPaQlh8K7Hk3aTNLD4JjW2Efcx4+V1ovuXNU8zPYZBL7t i4Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=40xzA7/CCtF2ieDGz/5A6zTdi4pEKj1ctuSk4L11Ksw=; b=fUqHLyGqgq0D5c/PDj9fSrA/09iq7S9vxGB3ZbTEbYTNWL9LMsEmFvhjcbIm4dqLCD n/wxO1WToOjrEqE2JUBZwGfgTQgCEFTsS9ex0UHLpnUtZA33g0WuQRdkaa6C5gAsEsqk qQOKrK6FQmNDjsCLuOIBx936iLetfZ750+OHyXUg8ZFKfwMuodGmnN60Z6Ui0VcxfA1P IM1bxuAzuCrgAgfe2P7EgpqZ53ZW8DPfIXwfXO1AYL7m0uK5ZA02YJSEB+GTQiws//yE fkevQeyBr3rQII6yJsDwY/PslT/bW5HABvZyQ07h7MqfU84GCNoikzkc13sbAG0i3Kfk KmHw== X-Gm-Message-State: APjAAAVvXMmCBae8YM/xQU9U5C04bATxlBlL5MF/JbuYUqJvvntSm1c5 oJrlgoTLpbUUbyKIAWMZflQyv+fMfI4ccaKnIEYstf4i X-Google-Smtp-Source: APXvYqy5kHeF2tH7PfSiu0+CQbxf3iwUhrZlOnsyKWOk0DkYkzinv3fTkw1DezpzQQf9Pe5OrICPjb9M4SNKutXVvwU= X-Received: by 2002:a02:a919:: with SMTP id n25mr12823321jam.140.1575663007896; Fri, 06 Dec 2019 12:10:07 -0800 (PST) MIME-Version: 1.0 References: <201912061255.xB6CtdJw011374@repo.freebsd.org> <7160a41739e5b251b50defb44ad08f3c722ea9c7.camel@freebsd.org> In-Reply-To: <7160a41739e5b251b50defb44ad08f3c722ea9c7.camel@freebsd.org> From: Luiz Otavio O Souza Date: Fri, 6 Dec 2019 17:09:56 -0300 Message-ID: Subject: Re: svn commit: r355444 - in head/sys: arm/mv arm64/conf conf To: Ian Lepore Cc: Luiz Otavio O Souza , src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 47V3bj1qt7z3LYw X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Dec 2019 20:10:09 -0000 On Fri, Dec 6, 2019 at 1:58 PM Ian Lepore wrote: > > On Fri, 2019-12-06 at 12:55 +0000, Luiz Otavio O Souza wrote: > > Author: loos > > Date: Fri Dec 6 12:55:39 2019 > > New Revision: 355444 > > URL: https://svnweb.freebsd.org/changeset/base/355444 > > > > Log: > > Add the SPI driver for the Marvell Armada 37x0 SoC. > > > > Interrupt based driver, implements SPI mode and clock configuration. > > > > Tested on espressobin and SG-3200. > > > > Sponsored by: Rubicon Communications, LLC (Netgate) > > > > Added: > > head/sys/arm/mv/a37x0_spi.c (contents, props changed) > > Modified: > > head/sys/arm64/conf/GENERIC > > head/sys/conf/files.arm64 > > > > Added: head/sys/arm/mv/a37x0_spi.c > > > > > > +static int > > +a37x0_spi_detach(device_t dev) > > +{ > > + struct a37x0_spi_softc *sc; > > + > > + bus_generic_detach(dev); > > > > It's possible for detaching children to fail (like if one of them > returns EBUSY from its detach), in which case you should bail on your > detach and return the error status. Also, this needs a > device_destroy_children() here after detaching them, to remove the > spibus child added in attach (in case the module is unloaded then > reloaded, that avoids adding a second copy of the child). > Fixed in r355461. Thanks Ian. Luiz