From owner-svn-src-head@freebsd.org Thu May 10 13:27:55 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CFB06FC95F5; Thu, 10 May 2018 13:27:55 +0000 (UTC) (envelope-from gallatin@cs.duke.edu) Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 716147DB20; Thu, 10 May 2018 13:27:55 +0000 (UTC) (envelope-from gallatin@cs.duke.edu) Received: from [192.168.200.3] (c-73-216-227-39.hsd1.va.comcast.net [73.216.227.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: gallatin) by duke.cs.duke.edu (Postfix) with ESMTPSA id AFED527001DB; Thu, 10 May 2018 09:18:05 -0400 (EDT) DMARC-Filter: OpenDMARC Filter v1.3.1 duke.cs.duke.edu AFED527001DB Authentication-Results: duke.cs.duke.edu; dmarc=none header.from=cs.duke.edu DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=cs.duke.edu; s=mail0816; t=1525958285; bh=CjHbqIepk+9d/E9zOVr847iDvBuoa4Ixjj4Qi9OIcec=; h=Subject:To:From:Date:From; b=i0/gxZyKhjjYY5da0Hn6FZw1I/bfNJmPYuvU0TkpWNUfJs8YqEozyb/WmPwDj4Okn 1v3eh2eB5Flrh667hlHm5fzNVLyYzReIPr3gprYciiQJ4uAq2kd9JDFej0/YCkZ7OC oyr4Ockdr7SZI2MeMXovZDOmrDQS68gmbEd5MMXt9TTMCErnLuDGQ0qRBh4C1x3DYs phMJLapm020mb+9vhA8RY5BPzmzaMAF575m9SZFm0EVHMP348wVzByWTulnKu+TTZ8 lFH4cCEbwoHzkRXUr/e/uEsT0GvpsnSJTRmeG4aDCU7hgKFRUrMT/ocPQtXKSPyqB1 Yj5ob75W1SiJA== Subject: Re: svn commit: r333457 - head/sys/kern To: Ed Maste , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201805101136.w4ABaG7G034274@repo.freebsd.org> From: Andrew Gallatin Message-ID: Date: Thu, 10 May 2018 09:18:04 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <201805101136.w4ABaG7G034274@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 13:27:56 -0000 On 05/10/18 07:36, Ed Maste wrote: > Author: emaste > Date: Thu May 10 11:36:16 2018 > New Revision: 333457 > URL: https://urldefense.proofpoint.com/v2/url?u=https-3A__svnweb.freebsd.org_changeset_base_333457&d=DwIDaQ&c=imBPVzF25OnBgGmVOlcsiEgHoG1i6YHLR0Sj_gZ4adc&r=Ed-falealxPeqc22ehgAUCLh8zlZbibZLSMWJeZro4A&m=Y7TkuLso5vnwZN5ypgs4eLKVEdMOSRgvhZZz1iAMdyU&s=-shrydFGkcYwmYlaG3W1nMyk2hg7rbKzCPfHI8_6GYM&e= > > Log: > ANSIfy sys_generic.c > > Modified: > head/sys/kern/sys_generic.c > > Modified: head/sys/kern/sys_generic.c > ============================================================================== > --- head/sys/kern/sys_generic.c Thu May 10 09:37:54 2018 (r333456) > +++ head/sys/kern/sys_generic.c Thu May 10 11:36:16 2018 (r333457) <..> > @@ -532,11 +519,7 @@ sys_pwritev(struct thread *td, struct pwritev_args *ua > } > > int > -kern_pwritev(td, fd, auio, offset) > - struct thread *td; > - struct uio *auio; > - int fd; > - off_t offset; > +kern_pwritev(struct thread *td, struct uio *auio, int fd, off_t offset) > { > struct file *fp; > int error; This breaks the kernel build: /usr/src/sys/kern/sys_generic.c:522:1: error: conflicting types for 'kern_pwritev' kern_pwritev(struct thread *td, struct uio *auio, int fd, off_t offset) ^ /usr/src/sys/sys/syscallsubr.h:212:5: note: previous declaration is here int kern_pwritev(struct thread *td, int fd, struct uio *auio, off_t offset); ^ 1 error generated. *** [sys_generic.o] Error code 1 I think the problem was that the non-ansi args were enumerated in a different order than their type declarations. Drew