From owner-svn-src-all@freebsd.org Tue Mar 7 03:31:40 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DC5B7D00FE5; Tue, 7 Mar 2017 03:31:40 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9456714E6; Tue, 7 Mar 2017 03:31:40 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id v273Vcia092093; Mon, 6 Mar 2017 19:31:38 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id v273VcBc092092; Mon, 6 Mar 2017 19:31:38 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201703070331.v273VcBc092092@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r314819 - stable/11/lib/libutil In-Reply-To: <699FBEE3-2379-414E-9E50-C3F726212949@gmail.com> To: "Ngie Cooper (yaneurabeya)" Date: Mon, 6 Mar 2017 19:31:38 -0800 (PST) CC: rgrimes@freebsd.org, Ngie Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 03:31:41 -0000 [ Charset UTF-8 unsupported, converting... ] > > > On Mar 6, 2017, at 19:10, Ngie Cooper (yaneurabeya) wrote: > > > >> > >> On Mar 6, 2017, at 19:00, Rodney W. Grimes wrote: > >> > >> [ Charset UTF-8 unsupported, converting... ] > >>> Author: ngie > >>> Date: Tue Mar 7 01:58:39 2017 > >>> New Revision: 314819 > >>> URL: https://svnweb.freebsd.org/changeset/base/314819 > >>> > >>> Log: > >>> MFC r313438: > >>> > >>> Clean up trailing and leading whitespace for variables to make it > >>> consistent with the rest of the file and style.Makefile(9) a bit > >>> more > >>> > >>> Modified: > >>> stable/11/lib/libutil/Makefile > >>> Directory Properties: > >>> stable/11/ (props changed) > >>> > >>> Modified: stable/11/lib/libutil/Makefile > >>> ============================================================================== > >>> --- stable/11/lib/libutil/Makefile Tue Mar 7 01:52:56 2017 (r314818) > >>> +++ stable/11/lib/libutil/Makefile Tue Mar 7 01:58:39 2017 (r314819) > >>> @@ -35,7 +35,7 @@ MAN+= expand_number.3 flopen.3 fparseln. > >>> property.3 pty.3 quotafile.3 realhostname.3 realhostname_sa.3 \ > >>> _secure_path.3 trimdomain.3 uucplock.3 pw_util.3 > >>> MAN+= login.conf.5 > >>> -MLINKS+= kld.3 kld_isloaded.3 kld.3 kld_load.3 > >>> +MLINKS+=kld.3 kld_isloaded.3 kld.3 kld_load.3 > >>> MLINKS+=login_auth.3 auth_cat.3 login_auth.3 auth_checknologin.3 > >>> MLINKS+=login_cap.3 login_close.3 login_cap.3 login_getcapbool.3 \ > >> > >> Thats actually counter style.Makefile(9), Normally you have a tab here, > >> or a space should the variable name extend beyond column 9. > >> > >>> login_cap.3 login_getcaplist.3 login_cap.3 login_getcapnum.3 \ > >>> @@ -57,9 +57,9 @@ MLINKS+=pidfile.3 pidfile_close.3 \ > >>> pidfile.3 pidfile_open.3 \ > >>> pidfile.3 pidfile_remove.3 \ > >>> pidfile.3 pidfile_write.3 > >>> -MLINKS+= property.3 property_find.3 property.3 properties_free.3 > >>> -MLINKS+= property.3 properties_read.3 > >>> -MLINKS+= pty.3 forkpty.3 pty.3 openpty.3 > >>> +MLINKS+=property.3 property_find.3 property.3 properties_free.3 > >>> +MLINKS+=property.3 properties_read.3 > >>> +MLINKS+=pty.3 forkpty.3 pty.3 openpty.3 > >> > >> Ditto. > > > > Yeah, I tried to leave things alone (except is surrounding areas for the following change), but I?ll go and hack away at the Makefile some more. > > Thanks, > > Actually, on second thought, I?m not going to modify the Makefile to just introduce gratuitous whitespace. If I need to touch this again, I?ll do it, but it doesn?t make sense churning over this Makefile like that (it?s a mishmash of different ?styles?). I am less concered about fixing this and more concerned about making sure you understood what the actual sytle.Makeilfe(9) rules are becuase it appeared that given the counter style changes you thought there should be no white space after VAR= in a Makefile. You probably understand that better than most and this is just a poor choice of words in the commit message. > -Ngie -- Rod Grimes rgrimes@freebsd.org