Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 28 Jul 2020 14:43:28 -0600
From:      Adam Weinberger <adamw@adamw.org>
To:        Cy Schubert <Cy.Schubert@cschubert.com>
Cc:        Rodrigo Osorio <rodrigo@freebsd.org>, ports-committers <ports-committers@freebsd.org>,  svn-ports-all <svn-ports-all@freebsd.org>, svn-ports-head <svn-ports-head@freebsd.org>
Subject:   Re: svn commit: r543580 - in head/net/rsync: . files
Message-ID:  <CAP7rwcidUs8muT6dHCnPuHYOcBDdkuX4P1Mk%2B9f09PWjk0ji6g@mail.gmail.com>
In-Reply-To: <202007282034.06SKYrtV006835@slippy.cwsent.com>
References:  <202007280659.06S6xa4M088583@repo.freebsd.org> <CAP7rwcji4YRd5EYVw=7ym77VuCc=KwjwdUi8JCBceKqufWPJWg@mail.gmail.com> <CAP7rwcjBe9x7my-gKNNQaRa3CCeydTsJ6X7StOoEM=EXN-O9WA@mail.gmail.com> <202007281441.06SEf15s070772@slippy.cwsent.com> <CAP7rwcjoMDzgP44hLUBD7De=jZcUoKJjEoMTqib9f2C9Fv1-EA@mail.gmail.com> <202007282034.06SKYrtV006835@slippy.cwsent.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 28, 2020 at 2:36 PM Cy Schubert <Cy.Schubert@cschubert.com> wrote:
>
> In message <CAP7rwcjoMDzgP44hLUBD7De=jZcUoKJjEoMTqib9f2C9Fv1-EA@mail.gmail.c
> om>
> , Adam Weinberger writes:
> > On Tue, Jul 28, 2020 at 8:42 AM Cy Schubert <Cy.Schubert@cschubert.com> wrote
> > :
> > >
> > > In message <CAP7rwcjBe9x7my-gKNNQaRa3CCeydTsJ6X7StOoEM=EXN-O9WA@mail.gmail.
> > c
> > > om>
> > > , Adam Weinberger writes:
> > > > On Tue, Jul 28, 2020 at 2:12 AM Adam Weinberger <adamw@adamw.org> wrote:
> > > > >
> > > > > On Tue, Jul 28, 2020 at 12:59 AM Rodrigo Osorio <rodrigo@freebsd.org> w
> > rote
> > > > :
> > > > > >
> > > > > > Author: rodrigo
> > > > > > Date: Tue Jul 28 06:59:35 2020
> > > > > > New Revision: 543580
> > > > > > URL: https://svnweb.freebsd.org/changeset/ports/543580
> > > > > >
> > > > > > Log:
> > > > > >   net/rsync upgrade to 3.2.2
> > > > > >
> > > > > > Modified: head/net/rsync/distinfo
> > > > > > =====================================================================
> > ====
> > > > =====
> > > > > > --- head/net/rsync/distinfo     Tue Jul 28 06:43:16 2020        (r543
> > 579)
> > > > > > +++ head/net/rsync/distinfo     Tue Jul 28 06:59:35 2020        (r543
> > 580)
> > > > > > @@ -1,5 +1,9 @@
> > > > > > -TIMESTAMP = 1518368927
> > > > > > -SHA256 (rsync-3.1.3.tar.gz) = 55cc554efec5fdaad70de921cd5a5eeb6c29a9
> > 5524
> > > > c715f3bbf849235b0800c0
> > > > > > -SIZE (rsync-3.1.3.tar.gz) = 905908
> > > > > > -SHA256 (rsync-patches-3.1.3.tar.gz) = 0dc2848f20ca75c07a30c3237ccf8d
> > 61b6
> > > > 1082ae7de94758a27dac350c99fb98
> > > > > > -SIZE (rsync-patches-3.1.3.tar.gz) = 174524
> > > > > > +TIMESTAMP = 1594065295
> > > > > > +SHA256 (rsync-3.2.2.tar.gz) = 644bd3841779507665211fd7db8359c8a10670
> > c57e
> > > > 305b4aab61b4e40037afa8
> > > > > > +SIZE (rsync-3.2.2.tar.gz) = 1057001
> > > > > > +SHA256 (rsync-patches-3.2.2.tar.gz) = eeccf4c7f178c936e451b679e64b67
> > 0f70
> > > > 7b989b7a40e2d22286407f8987ae9a
> > > > > > +SIZE (rsync-patches-3.2.2.tar.gz) = 286274
> > > > > > +SHA256 (rsync-patches-3.2.2.tar.gz) = eeccf4c7f178c936e451b679e64b67
> > 0f70
> > > > 7b989b7a40e2d22286407f8987ae9a
> > > > > > +SIZE (rsync-patches-3.2.2.tar.gz) = 286274
> > > > > > +SHA256 (rsync-patches-3.2.2.tar.gz) = eeccf4c7f178c936e451b679e64b67
> > 0f70
> > > > 7b989b7a40e2d22286407f8987ae9a
> > > > > > +SIZE (rsync-patches-3.2.2.tar.gz) = 286274
> > > > >
> > > > > Hi Rodrigo,
> > > > >
> > > > > The duplicated entries for the same file caused fetch to error out. I
> > > > > removed the duplicate entries. Do you know where the duplicates came
> > > > > from?
> > > >
> > > > Past the fetch failure, this also doesn't configure. Is it possible
> > > > that a patch didn't get added?
> > > >
> > > > # Adam
> > > >
> > > >
> > > >   checking whether to enable xxhash checksum support... no
> > > >   configure.sh: error: Failed to find xxhash.h for xxhash checksum suppor
> > t.
> > > >   Use --disable-xxhash to continue without it.
> > > >   ===>  Script "configure" failed unexpectedly.
> > > >   Please report the problem to rodrigo@FreeBSD.org [maintainer] and attac
> > h th
> > > > e
> > > >   "/wrkdirs/usr/ports/net/rsync/work/rsync-3.2.2/config.log" including th
> > e
> > > >   output of the failure of your make command. Also, it might be a good id
> > ea t
> > > > o
> > > >   provide an overview of all packages installed on your system (e.g. a
> > > >   /usr/local/sbin/pkg-static info -g -Ea).
> > > >   *** Error code 1
> > > >
> > > >   Stop.
> > > >   make: stopped in /usr/ports/net/rsync
> > > >   =>> Cleaning up wrkdir
> > > >   ===>  Cleaning for rsync-3.2.2
> > >
> > > Looks like it's missing a DEPENDS.
> >
> > It depends on xxhash. I suspect it's missing a configure arg.
>
> I got the same error until I installed xxhash by hand. It did not
> automatically install xxhash as one would expect.

I think the issue is that when ICONV and POPT are both off, rsync is
missing -I${LOCALBASE}/include -L${LOCALBASE}/lib. Now that xxhash is
a global dependency, they need to be explicit.

There seem to be a couple other dependency issues as well. In the
default configuration:
Warning: you need USES=ssl
Error: /usr/local/bin/rsync is linked to /usr/local/lib/liblz4.so.1
from archivers/liblz4 but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=liblz4.so:archivers/liblz4
Warning: Possible REINPLACE_CMD issues
sed failed: file content unchanged from backup: Makefile.in
sed failed: file content unchanged from backup: rsync.h

# Adam


-- 
Adam Weinberger
adamw@adamw.org
https://www.adamw.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAP7rwcidUs8muT6dHCnPuHYOcBDdkuX4P1Mk%2B9f09PWjk0ji6g>