From owner-svn-ports-all@freebsd.org Tue Jul 28 20:43:46 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 115FA374142 for ; Tue, 28 Jul 2020 20:43:46 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BGTD13Vk3z3d15 for ; Tue, 28 Jul 2020 20:43:45 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by mail-wm1-x342.google.com with SMTP id k20so820098wmi.5 for ; Tue, 28 Jul 2020 13:43:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JY7YA1/q8viQhXyCcSmIneD3Dm/kVcACJG7el9vYI4s=; b=yVCsIS4nROviEle9XHM4G8Gupt5c7RTjs0wwV64vnfZolr5IxcOkaqV+ArbkN4GYQt evyBRpqjIhbsCplYBPIb09ndbQSGBLW+VU1ay/q3IVYyHdnX/9uJpWC5xDkn3W29N9KL SYgInfxwCdqAwuu4yPFQaYixyxZaxcC1DF300LqwWEcTMJ7dMo1ADiO9269fZsDG9XSf exkOv1P0FFJgG8GnUUtp99LsDobhFJsXmBT8JZs4Oa69O5DBNtf4M6cicI9TozB5JzVm sCoUs8bWiNEuRFQsalySg3Q/f6VTxzH14DqDdeA7/qx0WgpB9SnNBGHzIIm1Cz4JjzrS UdjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JY7YA1/q8viQhXyCcSmIneD3Dm/kVcACJG7el9vYI4s=; b=EFERBlxfnJ4Xx+mJmiiJ6NSfeLPMJEEON4LSuqXetegNbLDX8wNAJg0dY4eWOLePTu cWztPXOKWRyfCL4JYB35MJckJKkMw3Y6WXoOyz+ekT44SSL6gsfe66TvfEdeo6y4YKcf FrUu7qlY7h+IiiDfRNof8lBA0oDPBJ4Q8KeeBZRdMMnZeVTv/XZ9iZ9cMGa0h0M/Yp9/ ZeHu/i3w67MfNpTIQz6v62VmZfJJaMRWR6heCCpk+Vpzkwq767myXCV/yNGD4KH85TAc LRpR9ReAyEj5caBFh4Q8JykTpd8Pfzes1fA0ckqYqDc71ADUqINFrGWREIYyS4q72t9N 6F0Q== X-Gm-Message-State: AOAM532kFBr1If8Qy3HEbLlfPBE+gZoNU/xcxb242C2UBP7NOdKV2X8X 1E5fV7N7v4xyyublRAVKYOSJeTfymQCLdm8vH8hBKnxSoJy9Dw== X-Google-Smtp-Source: ABdhPJxGQtFL5iRS0QWOiWhRoQwkwqHlhE3GdKrjcmdNcdL8ez7q8L8unXJ5XbnUgG/nr8DOxY748PwKgt7bJYr1tdY= X-Received: by 2002:a7b:ce0e:: with SMTP id m14mr5861135wmc.160.1595969024074; Tue, 28 Jul 2020 13:43:44 -0700 (PDT) MIME-Version: 1.0 References: <202007280659.06S6xa4M088583@repo.freebsd.org> <202007281441.06SEf15s070772@slippy.cwsent.com> <202007282034.06SKYrtV006835@slippy.cwsent.com> In-Reply-To: <202007282034.06SKYrtV006835@slippy.cwsent.com> From: Adam Weinberger Date: Tue, 28 Jul 2020 14:43:28 -0600 Message-ID: Subject: Re: svn commit: r543580 - in head/net/rsync: . files To: Cy Schubert Cc: Rodrigo Osorio , ports-committers , svn-ports-all , svn-ports-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4BGTD13Vk3z3d15 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=adamw-org.20150623.gappssmtp.com header.s=20150623 header.b=yVCsIS4n; dmarc=none; spf=pass (mx1.freebsd.org: domain of adamw@adamw.org designates 2a00:1450:4864:20::342 as permitted sender) smtp.mailfrom=adamw@adamw.org X-Spamd-Result: default: False [-2.50 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; R_DKIM_ALLOW(-0.20)[adamw-org.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; NEURAL_HAM_LONG(-1.02)[-1.022]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-ports-all@freebsd.org]; DMARC_NA(0.00)[adamw.org]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[adamw-org.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::342:from]; NEURAL_SPAM_SHORT(0.02)[0.018]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2020 20:43:46 -0000 On Tue, Jul 28, 2020 at 2:36 PM Cy Schubert wrote: > > In message om> > , Adam Weinberger writes: > > On Tue, Jul 28, 2020 at 8:42 AM Cy Schubert wrote > > : > > > > > > In message > c > > > om> > > > , Adam Weinberger writes: > > > > On Tue, Jul 28, 2020 at 2:12 AM Adam Weinberger wrote: > > > > > > > > > > On Tue, Jul 28, 2020 at 12:59 AM Rodrigo Osorio w > > rote > > > > : > > > > > > > > > > > > Author: rodrigo > > > > > > Date: Tue Jul 28 06:59:35 2020 > > > > > > New Revision: 543580 > > > > > > URL: https://svnweb.freebsd.org/changeset/ports/543580 > > > > > > > > > > > > Log: > > > > > > net/rsync upgrade to 3.2.2 > > > > > > > > > > > > Modified: head/net/rsync/distinfo > > > > > > ===================================================================== > > ==== > > > > ===== > > > > > > --- head/net/rsync/distinfo Tue Jul 28 06:43:16 2020 (r543 > > 579) > > > > > > +++ head/net/rsync/distinfo Tue Jul 28 06:59:35 2020 (r543 > > 580) > > > > > > @@ -1,5 +1,9 @@ > > > > > > -TIMESTAMP = 1518368927 > > > > > > -SHA256 (rsync-3.1.3.tar.gz) = 55cc554efec5fdaad70de921cd5a5eeb6c29a9 > > 5524 > > > > c715f3bbf849235b0800c0 > > > > > > -SIZE (rsync-3.1.3.tar.gz) = 905908 > > > > > > -SHA256 (rsync-patches-3.1.3.tar.gz) = 0dc2848f20ca75c07a30c3237ccf8d > > 61b6 > > > > 1082ae7de94758a27dac350c99fb98 > > > > > > -SIZE (rsync-patches-3.1.3.tar.gz) = 174524 > > > > > > +TIMESTAMP = 1594065295 > > > > > > +SHA256 (rsync-3.2.2.tar.gz) = 644bd3841779507665211fd7db8359c8a10670 > > c57e > > > > 305b4aab61b4e40037afa8 > > > > > > +SIZE (rsync-3.2.2.tar.gz) = 1057001 > > > > > > +SHA256 (rsync-patches-3.2.2.tar.gz) = eeccf4c7f178c936e451b679e64b67 > > 0f70 > > > > 7b989b7a40e2d22286407f8987ae9a > > > > > > +SIZE (rsync-patches-3.2.2.tar.gz) = 286274 > > > > > > +SHA256 (rsync-patches-3.2.2.tar.gz) = eeccf4c7f178c936e451b679e64b67 > > 0f70 > > > > 7b989b7a40e2d22286407f8987ae9a > > > > > > +SIZE (rsync-patches-3.2.2.tar.gz) = 286274 > > > > > > +SHA256 (rsync-patches-3.2.2.tar.gz) = eeccf4c7f178c936e451b679e64b67 > > 0f70 > > > > 7b989b7a40e2d22286407f8987ae9a > > > > > > +SIZE (rsync-patches-3.2.2.tar.gz) = 286274 > > > > > > > > > > Hi Rodrigo, > > > > > > > > > > The duplicated entries for the same file caused fetch to error out. I > > > > > removed the duplicate entries. Do you know where the duplicates came > > > > > from? > > > > > > > > Past the fetch failure, this also doesn't configure. Is it possible > > > > that a patch didn't get added? > > > > > > > > # Adam > > > > > > > > > > > > checking whether to enable xxhash checksum support... no > > > > configure.sh: error: Failed to find xxhash.h for xxhash checksum suppor > > t. > > > > Use --disable-xxhash to continue without it. > > > > ===> Script "configure" failed unexpectedly. > > > > Please report the problem to rodrigo@FreeBSD.org [maintainer] and attac > > h th > > > > e > > > > "/wrkdirs/usr/ports/net/rsync/work/rsync-3.2.2/config.log" including th > > e > > > > output of the failure of your make command. Also, it might be a good id > > ea t > > > > o > > > > provide an overview of all packages installed on your system (e.g. a > > > > /usr/local/sbin/pkg-static info -g -Ea). > > > > *** Error code 1 > > > > > > > > Stop. > > > > make: stopped in /usr/ports/net/rsync > > > > =>> Cleaning up wrkdir > > > > ===> Cleaning for rsync-3.2.2 > > > > > > Looks like it's missing a DEPENDS. > > > > It depends on xxhash. I suspect it's missing a configure arg. > > I got the same error until I installed xxhash by hand. It did not > automatically install xxhash as one would expect. I think the issue is that when ICONV and POPT are both off, rsync is missing -I${LOCALBASE}/include -L${LOCALBASE}/lib. Now that xxhash is a global dependency, they need to be explicit. There seem to be a couple other dependency issues as well. In the default configuration: Warning: you need USES=ssl Error: /usr/local/bin/rsync is linked to /usr/local/lib/liblz4.so.1 from archivers/liblz4 but it is not declared as a dependency Warning: you need LIB_DEPENDS+=liblz4.so:archivers/liblz4 Warning: Possible REINPLACE_CMD issues sed failed: file content unchanged from backup: Makefile.in sed failed: file content unchanged from backup: rsync.h # Adam -- Adam Weinberger adamw@adamw.org https://www.adamw.org