From owner-svn-src-all@FreeBSD.ORG  Wed Feb 25 22:07:24 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2002A1065670;
	Wed, 25 Feb 2009 22:07:24 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id D40E38FC15;
	Wed, 25 Feb 2009 22:07:23 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id n1PM52gt053359;
	Wed, 25 Feb 2009 15:05:02 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Wed, 25 Feb 2009 15:05:16 -0700 (MST)
Message-Id: <20090225.150516.708866590.imp@bsdimp.com>
To: ed@80386.nl
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20090225205253.GT19161@hoeg.nl>
References: <20090225194228.GS19161@hoeg.nl>
	<1235593885.1273.80.camel@widget.2hip.net>
	<20090225205253.GT19161@hoeg.nl>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org, rnoland@FreeBSD.org
Subject: Re: svn commit: r189052 - head/sys/dev/drm
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Feb 2009 22:07:24 -0000

In message: <20090225205253.GT19161@hoeg.nl>
            Ed Schouten <ed@80386.nl> writes:
: * Robert Noland <rnoland@FreeBSD.org> wrote:
: > On Wed, 2009-02-25 at 20:42 +0100, Ed Schouten wrote:
: > > Hi Robert,
: > > 
: > > * Robert Noland <rnoland@FreeBSD.org> wrote:
: > > > +static struct drm_msi_blacklist_entry drm_msi_blacklist[] = {
: > > > +	{0x8086, 0x2772}, /* Intel i945G	*/ \
: > > > +	{0x8086, 0x27A2}, /* Intel i945GM	*/ \
: > > > +	{0x8086, 0x27AE}, /* Intel i945GME	*/ \
: > > > +	{0, 0}
: > > > +};
: > > 
: > > Wouldn't it be better to use PCI_VENDOR_INTEL/PCI_PRODUCT_INTEL_*
: > > definitions here?
: > 
: > Where are those located?  The rest of drm just uses the hex id's, if
: > there is a better way, I'm up for it.
: 
: Oh wait, I always thought they were part of some kind of central list,
: like usbdevs, but it turns out device drivers just #define them
: themselves. Never mind.

NetBSD has this, but it was never adapted by FreeBSD.

Warner