From owner-svn-src-all@FreeBSD.ORG Fri Jan 30 07:24:53 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 044591065674; Fri, 30 Jan 2009 07:24:53 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from smtp.timeweb.ru (smtp.timeweb.ru [217.170.79.85]) by mx1.freebsd.org (Postfix) with ESMTP id AE5888FC0C; Fri, 30 Jan 2009 07:24:52 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from [213.148.20.85] (helo=hive.panopticon) by smtp.timeweb.ru with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1LSn49-0002Vr-G9; Fri, 30 Jan 2009 09:41:25 +0300 Received: from hades.panopticon (hades.panopticon [192.168.0.32]) by hive.panopticon (Postfix) with ESMTP id 5959612DDE; Fri, 30 Jan 2009 01:54:45 +0300 (MSK) Received: by hades.panopticon (Postfix, from userid 1000) id B5E8B108838; Fri, 30 Jan 2009 01:55:18 +0000 (UTC) Date: Fri, 30 Jan 2009 01:55:18 +0000 From: Dmitry Marakasov To: "David E. O'Brien" Message-ID: <20090130015518.GA20404@hades.panopticon> References: <200901130653.n0D6rrNX092719@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <200901130653.n0D6rrNX092719@svn.freebsd.org> User-Agent: Mutt/1.5.18 (2008-05-17) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r187132 - head/usr.bin/make X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jan 2009 07:24:53 -0000 * David E. O'Brien (obrien@FreeBSD.org) wrote: I think this should be backed out. Those verbose messages: - Are completely unexpected, this violates POLA. - Do break recognizeable make output people are used to - Really uglify make output for some custom makefiles (for example, generated by cmake: --- po/it.gmo --- [ 2%] Generating it.gmo --- po/kn.gmo --- [ 3%] Generating kn.gmo --- po/lv.gmo --- [ 3%] Generating lv.gmo --- po/nb.gmo --- [ 3%] Generating nb.gmo There's golden unix way rule: silence is golden. So please back this out, as this will really annoy many people. > Author: obrien > Date: Tue Jan 13 06:53:53 2009 > New Revision: 187132 > URL: http://svn.freebsd.org/changeset/base/187132 > > Log: > Don't enable -Q by default - I've fixed the rescue build issue. > > Modified: > head/usr.bin/make/job.c > head/usr.bin/make/main.c > > Modified: head/usr.bin/make/job.c > ============================================================================== > --- head/usr.bin/make/job.c Tue Jan 13 06:52:51 2009 (r187131) > +++ head/usr.bin/make/job.c Tue Jan 13 06:53:53 2009 (r187132) > @@ -2362,8 +2362,7 @@ Job_Init(int maxproc) > makeErrors = 0; > > lastNode = NULL; > - > - if ((maxJobs == 1 && fifoFd < 0) || beQuiet || beVerbose == 0) { > + if ((maxJobs == 1 && fifoFd < 0) || is_posix || beQuiet) { > /* > * If only one job can run at a time, there's no need for a > * banner, no is there? > > Modified: head/usr.bin/make/main.c > ============================================================================== > --- head/usr.bin/make/main.c Tue Jan 13 06:52:51 2009 (r187131) > +++ head/usr.bin/make/main.c Tue Jan 13 06:53:53 2009 (r187132) > @@ -126,7 +126,7 @@ Boolean is_posix; /* .POSIX target seen > Boolean mfAutoDeps; /* .MAKEFILEDEPS target seen */ > Boolean beSilent; /* -s flag */ > Boolean beVerbose; /* -v flag */ > -Boolean beQuiet = TRUE; /* -Q flag */ > +Boolean beQuiet; /* -Q flag */ > Boolean compatMake; /* -B argument */ > int debug; /* -d flag */ > Boolean ignoreErrors; /* -i flag */ > @@ -519,6 +519,7 @@ rearg: > break; > case 'Q': > beQuiet = TRUE; > + beVerbose = FALSE; > MFLAGS_append("-Q", NULL); > break; > case 'q': > _______________________________________________ > svn-src-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru