From owner-cvs-all Fri Nov 30 11:20:35 2001 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (gw.Awfulhak.org [217.204.245.18]) by hub.freebsd.org (Postfix) with ESMTP id 6E5EC37B405; Fri, 30 Nov 2001 11:20:20 -0800 (PST) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [fec0::1:12]) by Awfulhak.org (8.11.6/8.11.6) with ESMTP id fAUJKIR76096; Fri, 30 Nov 2001 19:20:18 GMT (envelope-from brian@freebsd-services.com) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.6/8.11.6) with ESMTP id fAUJKGE02104; Fri, 30 Nov 2001 19:20:16 GMT (envelope-from brian@freebsd-services.com) Message-Id: <200111301920.fAUJKGE02104@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Brian Somers Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, freebsd-net@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet in.c In-Reply-To: Message from Brian Somers of "Fri, 30 Nov 2001 06:00:55 PST." <200111301400.fAUE0tj62293@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 30 Nov 2001 19:20:16 +0000 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > brian 2001/11/30 06:00:55 PST > > Modified files: > sys/netinet in.c > Log: > During SIOCAIFADDR, if in_ifinit() fails and we've already added an > interface address, blow the address away again before returning the > error. > > In in_ifinit(), if we get an error from rtinit() and we've also got > a destination address, return the error rather than masking EEXISTS. > Failing to create a host route when configuring an interface should > be treated as an error. > > Revision Changes Path > 1.61 +39 -24 src/sys/netinet/in.c It's possible that EEXIST being returned from in_ifinit() should not be masked at all, except for the ``netmask == 0xffffffff'' case so that we can't have conflicting interface addresses.... I'm not sure about this though, so I've cc'd freebsd-net. -- Brian http://www.freebsd-services.com/ Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message