From owner-freebsd-bugs@FreeBSD.ORG Mon May 6 03:51:12 2013 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 12FBF443; Mon, 6 May 2013 03:51:12 +0000 (UTC) (envelope-from swhetzel@gmail.com) Received: from mail-ia0-x22f.google.com (mail-ia0-x22f.google.com [IPv6:2607:f8b0:4001:c02::22f]) by mx1.freebsd.org (Postfix) with ESMTP id D18ABD9D; Mon, 6 May 2013 03:51:11 +0000 (UTC) Received: by mail-ia0-f175.google.com with SMTP id i38so2865307iae.34 for ; Sun, 05 May 2013 20:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=IbmbpLYUwZ1tFCTHRp+10R94jG8x8Vje9lc1VHPcE4k=; b=FrTlavvQ0ME8fNutSEpKq1a8if/hBHe7EdEjCH+fz8XT/HJDwqzuiU10+jytF+SaFA qe8ADedl/GELCvgJPozGu7+/M7dxeHhqGNM9TuuqTla+78agi+a1+VqeH+KLSqb8NPRV 0OmIJkA3ko8BQ5KK1ee8cIkoeIhGUIhiZCUuq+Zho9/l456s4T/blTyMhH2wlnvD79uK vgcLX3XxX/4ZB7rGe+64e4tv0rRJ5bv1COwGfKkIxd1cI3PYcgdzBVSMW/7quI4brpsU J9Lv+mKDhJ5fqVRO1Lzz3rIPqqp3WDP43JWZkyeKNgPEWma2Nf9wVCYSrfWzKv7XDqB2 PzkQ== MIME-Version: 1.0 X-Received: by 10.50.62.14 with SMTP id u14mr2012240igr.41.1367812271006; Sun, 05 May 2013 20:51:11 -0700 (PDT) Received: by 10.50.66.162 with HTTP; Sun, 5 May 2013 20:51:10 -0700 (PDT) In-Reply-To: <201305060054.r460sVBh004810@freefall.freebsd.org> References: <201305060054.r460sVBh004810@freefall.freebsd.org> Date: Sun, 5 May 2013 22:51:10 -0500 Message-ID: Subject: Re: kern/178359: [geom] [patch] geom_eli: support external metadata From: Scot Hetzel To: freebsd-bugs@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Cc: Andrew Romanenko , freebsd-geom@freebsd.org X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 May 2013 03:51:12 -0000 On Sun, May 5, 2013 at 7:54 PM, wrote: > Old Synopsis: geom_eli: support external metadata > New Synopsis: [geom] [patch] geom_eli: support external metadata > > Responsible-Changed-From-To: freebsd-bugs->freebsd-geom > Responsible-Changed-By: linimon > Responsible-Changed-When: Mon May 6 00:54:16 UTC 2013 > Responsible-Changed-Why: > Over to maintainer(s). > > http://www.freebsd.org/cgi/query-pr.cgi?pr=178359 I had a quick look at the patch and noticed that it is using -H for init method, but -h for the attach, configure, setkey, delkey, resume, resize, and dump methods. The patch also shows that it removes the -h option from the init method. I looked at the -Current and release/9.1.0 sources for geom_eli.8 and they don't have the -h option. I suspect it was a local modification that was made before this patch was created. It would be best that init, attach, configure, setkey, delkey, resume, resize, and dump methods use the same option (-h or -H) to specify the headerfile. -- DISCLAIMER: No electrons were maimed while sending this message. Only slightly bruised.