Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 17 Apr 2000 17:51:35 -0400
From:      "Patrick Bihan-Faou" <patrick@mindstep.com>
To:        "Poul-Henning Kamp" <phk@critter.freebsd.dk>
Cc:        <freebsd-current@FreeBSD.ORG>
Subject:   Re: FreeBSD Build status
Message-ID:  <01a501bfa8b7$19f2fe60$040aa8c0@local.mindstep.com>
References:  <12411.956006235@critter.freebsd.dk>

next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.

------=_NextPart_000_01A2_01BFA895.92CBDA90
Content-Type: text/plain;
	charset="Windows-1252"
Content-Transfer-Encoding: 7bit

Hi,


I have a patch against these warnings. They are the result of a function
being called with a pointer to a function rather than a string...



/otte/src/gnu/usr.bin/cc/cc_int/../../../../contrib/gcc/c-common.c:1655:
warning: passing arg 1 of `warning' from incompatible pointer type
/otte/src/gnu/usr.bin/cc/cc_int/../../../../contrib/gcc/c-common.c:1655:
warning: passing arg 1 of `warning' from incompatible pointer type
/otte/src/gnu/usr.bin/cc/cc_int/../../../../contrib/gcc/c-common.c:1678:
warning: passing arg 1 of `warning' from incompatible pointer type
/otte/src/gnu/usr.bin/cc/cc_int/../../../../contrib/gcc/c-common.c:1678:
warning: passing arg 1 of `warning' from incompatible pointer type



The patch:

--- c-common.c.orig Mon Nov  1 13:41:09 1999
+++ c-common.c Sat Apr  8 06:32:52 2000
@@ -1652,7 +1652,7 @@
    /* There should be an int arg to control the string arg.  */
    if (params == 0)
      {
-       warning (tfaff);
+       tfaff ();
        return;
      }
      if (info->first_arg_num != 0)
@@ -1675,7 +1675,7 @@
    /* There should be an unsigned char * arg before the string arg.  */
    if (params == 0)
      {
-       warning (tfaff);
+       tfaff ();
        return;
      }
      if (info->first_arg_num != 0)




Should I just send a PR ?

Patrick.



------=_NextPart_000_01A2_01BFA895.92CBDA90
Content-Type: application/octet-stream;
	name="c-common.c.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
	filename="c-common.c.patch"

--- c-common.c.orig	Mon Nov  1 13:41:09 1999=0A=
+++ c-common.c	Sat Apr  8 06:32:52 2000=0A=
@@ -1652,7 +1652,7 @@=0A=
 	  /* There should be an int arg to control the string arg.  */=0A=
 	  if (params =3D=3D 0)=0A=
 	    {=0A=
-	      warning (tfaff);=0A=
+	      tfaff ();=0A=
 	      return;=0A=
 	    }=0A=
 	    if (info->first_arg_num !=3D 0)=0A=
@@ -1675,7 +1675,7 @@=0A=
 	  /* There should be an unsigned char * arg before the string arg.  */=0A=
 	  if (params =3D=3D 0)=0A=
 	    {=0A=
-	      warning (tfaff);=0A=
+	      tfaff ();=0A=
 	      return;=0A=
 	    }=0A=
 	    if (info->first_arg_num !=3D 0)=0A=

------=_NextPart_000_01A2_01BFA895.92CBDA90--



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?01a501bfa8b7$19f2fe60$040aa8c0>