From owner-freebsd-current@freebsd.org Mon Jan 4 17:05:18 2021 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2B69E4DCF09 for ; Mon, 4 Jan 2021 17:05:18 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D8hp51xJxz3KR7 for ; Mon, 4 Jan 2021 17:05:17 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-oi1-f173.google.com with SMTP id s2so32874004oij.2 for ; Mon, 04 Jan 2021 09:05:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rJneXXSYqnrhistM+uhT0Go8Dc12UblwAM4c/Qzi0UQ=; b=DOPxlOFwlzym1URUNjr9lRHhz5WXUKRwF4ch5oEUW2CXI2qjFr5YC0usjnupo9mwQ0 91FE8+ccm0cmApMspmWFNTtI2R4gcNH9PRYQ2rbESSZXMw6sdzMKL5xNqV4Nz3kEis96 ChXUJUD7LJbcWyFAs1/6KBVwItqrt8GIuOJTWR36etemFgZXJdIEnVYnBnHfeZ5/3ZwX Zul4vODZoXC6fWNG8fj6LGQBOCx7cXNyQo/jhWg19ONPJ5W3LSsPrCJXnaKAwa5ZlKEM H0g4G47pSda4BzBMmPJ0hQLa3nbGZbIU4LM5c+Rls026HAskwheWHEG0GwstU1A91RjV JQWg== X-Gm-Message-State: AOAM532z2HEo65BmAPydNT0QWTTwm5HCwfwpFiOzqDhqU4WUNNzVWkHG PeML3lbWXkiNm08K9QcSE94AZ44NM7KN2Gm9bM+baA3dVPA= X-Google-Smtp-Source: ABdhPJy41I5LtYiZtmmGS8iMZ191qdhX3Oy1SOkqlifmMtJnfW1rE4vYKqjfZaxVOE6HxQTkFvpXadEejNojGJ2v72c= X-Received: by 2002:aca:dd09:: with SMTP id u9mr18766405oig.73.1609779916174; Mon, 04 Jan 2021 09:05:16 -0800 (PST) MIME-Version: 1.0 References: <94447.1609779520@critter.freebsd.dk> In-Reply-To: <94447.1609779520@critter.freebsd.dk> From: Alan Somers Date: Mon, 4 Jan 2021 10:05:05 -0700 Message-ID: Subject: Re: git non-time-sequential logs To: Poul-Henning Kamp Cc: John Kennedy , Current FreeBSD X-Rspamd-Queue-Id: 4D8hp51xJxz3KR7 X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.00 / 15.00]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RBL_DBL_DONT_QUERY_IPS(0.00)[209.85.167.173:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FREEFALL_USER(0.00)[asomers]; R_DKIM_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; SPAMHAUS_ZRD(0.00)[209.85.167.173:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_IN_DNSWL_NONE(0.00)[209.85.167.173:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.167.173:from]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-current] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jan 2021 17:05:18 -0000 On Mon, Jan 4, 2021 at 9:58 AM Poul-Henning Kamp wrote: > -------- > John Kennedy writes: > > > This might be perfectly natural and just new to me, but when I look at > the > > git logs this morning I see things like this (editing by me): > > > > Date: Mon Jan 4 17:30:00 2021 +0100 > > Date: Mon Dec 14 18:56:56 2020 +0100 > > Date: Tue Dec 15 13:50:00 2020 +0100 > > Date: Mon Jan 4 16:23:10 2021 +0100 > > > > I've always assumed that the "Date:" there was when the commit > happened, > > It is, but it is the time it was committed in the first git repos it was > committed to, > in this case the repos of the committer in question. > > Without taking a position on the merits of this design-choice, I > just want to point out that it means that timestamps should be > viewed very sceptically, since they depend on the *local* clock on > somebodys computer, not on the central repos machine. > I'll be more frank than phk: it sucks. Git's commit dates are basically useless. But there are a few ways to improve the situation: 1) If we start using Gitlab or something similar, we can ban pushes directly to head. Then we'll be able to trust the Dates on Gitlab's merge commits. 2) Perhaps we can use the Git Notes to add a field for the Date when a commit was pushed to the master server? 3) The internet is full of suggestions for how to change the way commits are displayed locally to mediate this problem. But they all seem to involve changes to the working copy's configuration, not the master's. And I haven't gotten any way to work. -Alan