From owner-cvs-all Thu Feb 28 11: 0:51 2002 Delivered-To: cvs-all@freebsd.org Received: from rwcrmhc51.attbi.com (rwcrmhc51.attbi.com [204.127.198.38]) by hub.freebsd.org (Postfix) with ESMTP id 37C2837B405; Thu, 28 Feb 2002 11:00:28 -0800 (PST) Received: from InterJet.elischer.org ([12.232.206.8]) by rwcrmhc51.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020228190027.DMX2626.rwcrmhc51.attbi.com@InterJet.elischer.org>; Thu, 28 Feb 2002 19:00:27 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id KAA06774; Thu, 28 Feb 2002 10:58:04 -0800 (PST) Date: Thu, 28 Feb 2002 10:58:02 -0800 (PST) From: Julian Elischer To: Josef Karthauser Cc: Julian Elischer , peter@freebsd.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb ohci.c In-Reply-To: <20020228184733.GB15224@genius.tao.org.uk> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 28 Feb 2002, Josef Karthauser wrote: > On Thu, Feb 28, 2002 at 06:36:40PM +0000, Josef Karthauser wrote: > > On Wed, Feb 27, 2002 at 11:24:55AM -0800, Julian Elischer wrote: > > > julian 2002/02/27 11:24:55 PST > > > > > > Modified files: > > > sys/dev/usb ohci.c > > > Log: > > > Add a comment explaining a code change.. > > > > Please don't commit to the usb subsystem without feeding patches > > through me or I will give up and leave the merge from NetBSD to > > someone else. > > OK but we needed to get the kernel compiling again. The comments were because it wasn't obvious why the change was made and I could see that it would be reverted at the first oportunity without it.. Any movement on the fact that the usb code allocates 2K+ on the stack? > > I'm not putting a lock on this, but if you take a look at where we > are you'll find that we're currently about a year behind in commits > for the controller code. If we want USB2, etc, we need to refrain > from developing the usb subsystem until we're relatively in sync > with NetBSD - at which point we can easily hand them patches, and > we can all (*BSD) move forward together. > > I realise that earlier in the week there were some warnings in ohci > that stopped play and I don't mind patches that fix problems like > that, but if you want to work on this code you also have to take > responsibility for keeping it in sync with the other BSDs. The USB > code is wierd in that it's not really contrib/ material because > it's being developed in all the BSDs at the same time. FreeBSD, > however, is in a funny state because for some reason (probably lack > of someone's time) we're way behind the status quo, and we've > diverged slightly during that time because of global SMPng/KSE/etc > changes. > > My goal is to get us up to speed. I beg you to not make my life > harder than it already is. I assure you that I am working on this > stuff. (Three hours of hand patching code today already). > > Thanks, > Joe > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message