From owner-svn-src-head@FreeBSD.ORG Sat Jul 13 07:31:25 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 56D7EB03; Sat, 13 Jul 2013 07:31:25 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-lb0-x233.google.com (mail-lb0-x233.google.com [IPv6:2a00:1450:4010:c04::233]) by mx1.freebsd.org (Postfix) with ESMTP id 1428515EF; Sat, 13 Jul 2013 07:31:23 +0000 (UTC) Received: by mail-lb0-f179.google.com with SMTP id w20so8250843lbh.10 for ; Sat, 13 Jul 2013 00:31:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=N9MIz1E9XGwqRLjEPBBxb36I0XBI3z6EHFP2S5b6KDI=; b=HyIzA6aVxY0y4e/IH2J9pA9E9Q4I9dMUw7qyamlGnQbdhfbDl3A7w/wtBwNP835AIB lm7JcKyHjl7zg3xAR9Y6AdTNwjAFFjVhktGelIX2AP8rfSBCqxGoa9E9vr5AZvar0gAv Z33BTn6MbcOqrT+ZuZtjUqAGkBSRTQc/WLmmIt2pN0MiM6SkG1MagYkG16COWLx0zOxE UcCP+VKCK9NYYNr61zfyDPrv9qe0dN0gB14uzvedokMNtVN5Z4yzcFEX/RaBS5UHsQ0m OI/cn4Ct3wXd9qC+4LsX70Cfvhc9Ba+DSwLD6SAYFtJwcqjj9nZCPL0UYxLKBedXr/vC SD7Q== X-Received: by 10.152.115.194 with SMTP id jq2mr20626411lab.53.1373700683001; Sat, 13 Jul 2013 00:31:23 -0700 (PDT) Received: from localhost ([178.150.115.244]) by mx.google.com with ESMTPSA id x5sm15024221lbx.8.2013.07.13.00.31.21 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 13 Jul 2013 00:31:22 -0700 (PDT) Sender: Mikolaj Golub Date: Sat, 13 Jul 2013 10:31:19 +0300 From: Mikolaj Golub To: Adrian Chadd Subject: Re: svn commit: r253255 - head/sys/netgraph/bluetooth/drivers/ubt Message-ID: <20130713073118.GC2757@gmail.com> References: <201307120803.r6C83ACp016523@svn.freebsd.org> <20130712202710.GB2757@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Craig Rodrigues , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Marko Zec X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jul 2013 07:31:25 -0000 On Fri, Jul 12, 2013 at 10:40:08PM -0700, Adrian Chadd wrote: > Here's what I have running on my stable/9 VIMAGE laptop. > > http://people.freebsd.org/~adrian/ath/20130712-vimage-default-attach-detach.diff > > How's this look to put into -HEAD? Your patch looks similar to Marko's: http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20121115/0824ca85/attachment.diff Marko took your idea of setting vnet0 context in device_probe_and_attach(), although there is no is_default_vnet check, and I also think it is not necessary here -- just unconditionally set vnet0 is ok. Also, as I understand, after handling vnet context in device_probe_and_attach(), there is no need in curvnet setting in kldload/kldunload, and Marko removed it. In net/if.c, similarly to you, Marko sets vnet context in if_detach(), but also in if_free(), so this would be good to commit too (I suppose Marko had good reasons to do this). I can't comment the netgraph related parts of your patch as I have no idea what is going on here. Though I think this could be committed separately if it is needed. -- Mikolaj Golub