From owner-freebsd-arch@FreeBSD.ORG  Sun Mar 17 10:02:28 2013
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 16D132EA;
 Sun, 17 Mar 2013 10:02:28 +0000 (UTC) (envelope-from des@des.no)
Received: from smtp.des.no (smtp.des.no [194.63.250.102])
 by mx1.freebsd.org (Postfix) with ESMTP id C30509F7;
 Sun, 17 Mar 2013 10:02:27 +0000 (UTC)
Received: from ds4.des.no (smtp.des.no [194.63.250.102])
 by smtp-int.des.no (Postfix) with ESMTP id 4066FB9B1;
 Sun, 17 Mar 2013 10:02:26 +0000 (UTC)
Received: by ds4.des.no (Postfix, from userid 1001)
 id E66809A4B; Sun, 17 Mar 2013 11:02:25 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Konstantin Belousov <kostikbel@gmail.com>
Subject: Re: chflagsat(2).
References: <20130317004908.GB1364@garage.freebsd.pl>
 <20130317064338.GN3794@kib.kiev.ua>
Date: Sun, 17 Mar 2013 11:02:24 +0100
In-Reply-To: <20130317064338.GN3794@kib.kiev.ua> (Konstantin Belousov's
 message of "Sun, 17 Mar 2013 08:43:38 +0200")
Message-ID: <86d2uyl4y7.fsf@ds4.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: freebsd-arch@FreeBSD.org
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Mar 2013 10:02:28 -0000

Konstantin Belousov <kostikbel@gmail.com> writes:
> Pawel Jakub Dawidek <pjd@FreeBSD.org> writes:
> > Note that the name chflagsat was carefully choosen instead of
> > fchflagsat, to not repeat POSIX (more likely Linux) mistakes of using
> > fchmodat, fchownat, futimesat, etc. names when they really shouldn't
> > start with an 'f'.
> This is the only point I do not agree with the patch. I prefer to have
> the syscall name consistent with the other syscalls.

So do I, which is why I agree with Pawel's decision to call it
chflagsat() instead of fchflagsat():

int	openat(int, const char *, int, ...);
int	faccessat(int, const char *, int, int);
int	linkat(int, const char *, int, const char *, int);
ssize_t	readlinkat(int, const char * __restrict, char * __restrict, size_t);
int	symlinkat(const char *, int, const char *);
int	unlinkat(int, const char *, int);

etc.

Unfortunately, we also have

int	fchownat(int, const char *, uid_t, gid_t, int);

which makes as little sense as fchflagsat().

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no