From owner-svn-src-head@freebsd.org Thu Jun 14 01:01:19 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CC9EE100A028 for ; Thu, 14 Jun 2018 01:01:19 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic315-9.consmr.mail.gq1.yahoo.com (sonic315-9.consmr.mail.gq1.yahoo.com [98.137.65.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5557586D5A for ; Thu, 14 Jun 2018 01:01:19 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: vRTj9x4VM1nAK2hu2rybjZZcZzrFGmTekEs0HqQGX.H3oT2wpjFhX_39rOhhd2C PcsRzC4Fks.UQfZ.6rwFUHfDQjbZOqXSLBi5z2NVO0oUZWA7fDTJFKuvVHp.oRgaQIB7VH0nxScE tJQ5jh2kPw1iKwZlpJ_G44lKwT6dtZRjLlbS7i6wYefXPow.oPLUT6ZxpYbTlfj2r.n9krAv07Bs 8xcmHcaA3pc2SLOXj4gio.ZJEW9yewbGBtoibThnLAqukBreO0O4B71OxtgS4xWlYg92zLTXjnJb adNqvelsXlQaukzvTfEJp_SjTosSem9YGQjfV7YZxXRa5bYQ1CbYRbcR4SQxKjavO0X9EG36Cdhw YmeFL3LxAmrNgFfv7Ehl3lApn0KpBHIUWT8d6U.LoLJmSOW019mCRVdh9UaDqHteTWbbaI7szFc7 W4Y7geXDR05.t7M3gOYHJA8qhsleUIZv3T_zVZiv12GzVZ6Y2cz8JzDQ9V.iKdQfkn3dNS75VZqj rVGpjs_tvMQnEofDeiWLxQNGmTOXJQ46QiApLMBKVMsPTn47vi2gbsvfTIFoHyMhvIXAcWmVeF9m c64L.8vRrPdqHdtpCQTaBZcNtMjWpV5RK.qcdZV9j9y3TwMAf9NpE9.Riw9ZYP9gSaekc2j5B2w9 VOK2uxrhOytDzf2vrPUXg5f356.TxC7KOVBxhBBXa1DAF4m81gH_tn12Cg8ey1z2.g0pET_nwual dUEyq8WGgA5DUudeSQcBix8RvCoVhPepPiILguhb9JvPR63zJarIiXy0Vkznd.UqV_McEEQdOYvf LVdNhByDvObGiYcrzS4ozIMPXNfP6cCH8Pj0DMAKabuGDyhUqOlmGmBdU6STOhWR5BJLIwX7PsC9 EbhCANpxDI20sinxgQ8uBpkoEeFV87VsSk7qAYphnIeCY1Hbk9GtnNRViJTMZJfWeqIJy.pwsCc2 ttKi3KA-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.gq1.yahoo.com with HTTP; Thu, 14 Jun 2018 01:01:12 +0000 Received: from ip70-189-131-151.lv.lv.cox.net (EHLO [192.168.0.109]) ([70.189.131.151]) by smtp418.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 2d61148bf9bcb664212b0fee8380770a; Thu, 14 Jun 2018 01:01:08 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) Subject: Re: svn commit: r335091 - head/sbin/nvmecontrol [broke builds of FreeBSD-head-armv7-build and other 32-bit ci.freeb sd.org builds] Message-Id: <0A0EF5DB-CC1C-4A1E-8FAD-0D81CBAFC5B5@yahoo.com> Date: Wed, 13 Jun 2018 18:01:07 -0700 To: imp@FreeBSD.org, svn-src-head@freebsd.org X-Mailer: Apple Mail (2.3445.8.2) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jun 2018 01:01:20 -0000 Warner Losh imp at FreeBSD.org wrote on Wed Jun 13 22:00:04 UTC 2018 : > Author: imp > Date: Wed Jun 13 22:00:02 2018 > New Revision: 335091 > URL:=20 > https://svnweb.freebsd.org/changeset/base/335091 >=20 >=20 > Log: > Make it possible to use print_controller from another program > =20 > Rename print_controller to nvme_print_controller. Put it in its > own file for easy inclusion. Move util.c to be nc_util.c to not > conflict with camcontrol. add nvecontrol_ext.h to define shared > interfaces. > =20 > Sponsored by: Netflix > Differential Revision:=20 > https://reviews.freebsd.org/D15371 >=20 >=20 > Added: > head/sbin/nvmecontrol/identify_ext.c > - copied, changed from r335089, head/sbin/nvmecontrol/identify.c > head/sbin/nvmecontrol/nc_util.c > - copied, changed from r335089, head/sbin/nvmecontrol/util.c > head/sbin/nvmecontrol/nvmecontrol_ext.h (contents, props changed) > - copied, changed from r335089, head/sbin/nvmecontrol/util.c > Deleted: > head/sbin/nvmecontrol/util.c > Modified: > head/sbin/nvmecontrol/Makefile > head/sbin/nvmecontrol/identify.c . . . For 32-bit clang-based targets first . . . FreeBSD-head-armv7-build FreeBSD-head-armv6-build get build failures like: --- all_subdir_sbin --- In file included from /usr/src/sbin/nvmecontrol/identify_ext.c:43: /usr/src/sbin/nvmecontrol/nvmecontrol.h:112:9: error: unknown type name = '__uint128_t' typedef __uint128_t uint128_t; ^ 1 error generated. *** [identify_ext.o] Error code 1 For 32-bit gcc 4.2.1 targets second . . . FreeBSD-head-mips-build FreeBSD-head-powerpc-build FreeBSD-head-powerpcspe-build get build failures like: --- all_subdir_sbin --- In file included from /usr/src/sbin/nvmecontrol/identify_ext.c:43: /usr/src/sbin/nvmecontrol/nvmecontrol.h:112: error: expected '=3D', ',', = ';', 'asm' or '__attribute__' before 'uint128_t' /usr/src/sbin/nvmecontrol/nvmecontrol.h:116: error: expected '=3D', ',', = ';', 'asm' or '__attribute__' before 'to128' /usr/src/sbin/nvmecontrol/nvmecontrol.h:122: error: expected ')' before = 'u' cc1: warnings being treated as errors /usr/src/sbin/nvmecontrol/identify_ext.c: In function = 'nvme_print_controller': /usr/src/sbin/nvmecontrol/identify_ext.c:219: warning: implicit = declaration of function 'uint128_to_str' /usr/src/sbin/nvmecontrol/identify_ext.c:219: warning: nested extern = declaration of 'uint128_to_str' /usr/src/sbin/nvmecontrol/identify_ext.c:219: warning: implicit = declaration of function 'to128' /usr/src/sbin/nvmecontrol/identify_ext.c:219: warning: nested extern = declaration of 'to128' /usr/src/sbin/nvmecontrol/identify_ext.c:219: warning: format '%s' = expects type 'char *', but argument 2 has type 'int' /usr/src/sbin/nvmecontrol/identify_ext.c:221: warning: format '%s' = expects type 'char *', but argument 2 has type 'int' *** [identify_ext.o] Error code 1 =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)