From owner-cvs-all@FreeBSD.ORG Wed Oct 15 13:40:36 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D0F2C16A4B3; Wed, 15 Oct 2003 13:40:36 -0700 (PDT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id EF9DE43F85; Wed, 15 Oct 2003 13:40:34 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.10/8.12.10) with ESMTP id h9FKeW49046552; Wed, 15 Oct 2003 22:40:32 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Nate Lawson From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 15 Oct 2003 13:36:56 PDT." <20031015133353.W35236@root.org> Date: Wed, 15 Oct 2003 22:40:32 +0200 Message-ID: <46551.1066250432@critter.freebsd.dk> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys conf.h src/sys/fs/specfs spec_vnops.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Oct 2003 20:40:37 -0000 In message <20031015133353.W35236@root.org>, Nate Lawson writes: >I assume this is to avoid a trip through a vnode when doing IO to a >device? Can you point me at the analysis of this approach? I've heard >you talking about it before but don't have a reference. See the streams driver for an example why this can be considered merely a cleanup. >> @@ -223,6 +224,7 @@ >> u_int d_flags; >> const char *d_name; >> d_open_t *d_open; >> + d_fdopen_t *d_fdopen; >> d_close_t *d_close; >> d_read_t *d_read; >> d_write_t *d_write; > >Sure we have C99 now but for binary compatibility with third party >drivers, shouldn't this be added at the end of the structure? Especially >since this is an optional function. This was deliberately put in the logical place in order to encourage 3rdparty drivers to use the correct C99 initialization for cdevsw. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.