From owner-freebsd-net@FreeBSD.ORG Tue Aug 21 23:31:51 2007 Return-Path: Delivered-To: net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7F35A16A419 for ; Tue, 21 Aug 2007 23:31:51 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 73DE413C4DA for ; Tue, 21 Aug 2007 23:31:51 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 47E891A4D86; Tue, 21 Aug 2007 16:29:56 -0700 (PDT) Date: Tue, 21 Aug 2007 16:29:56 -0700 From: Alfred Perlstein To: net@freebsd.org Message-ID: <20070821232956.GT87451@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.3i Cc: Subject: Re: Allocating AF constants for vendors. X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2007 23:31:51 -0000 I trimmed the sender of this because I got it in private mail, that said I thought it was a good bunch of questions so I am replying to it. > 64? are you intending to bump AF_MAX or allocate them sequentially such > that adding another AF will require AF_MAX to grow a lot? > > In general this seems like a bad idea to me. I suggest you need to > (publicly) explain what you are doing and why this is a good idea. The goal here is to allow vendors to add their own constants without worrying about conflicting with FreeBSD constants. It will allow vendors to maintain some semblance of binary compatibility against FreeBSD. If you look at libpcap: http://cvs.tcpdump.org/cgi-bin/cvsweb/libpcap/pcap/bpf.h?rev=1.15 You can see that Juniper has asked for some number of reserved "families", in our case, I think it would be a bit greedy to grow the list _just_ for Juniper, so I suggested something that would work for every vendor. As far as implementation details, either one works for me, do you have any particular preference? Other than the actual delta, will this have any noticeable negative impact that you can see? -- - Alfred Perlstein