From owner-svn-ports-all@FreeBSD.ORG  Tue Dec 11 13:21:32 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 729BDCEB;
 Tue, 11 Dec 2012 13:21:32 +0000 (UTC)
 (envelope-from amdmi3@amdmi3.ru)
Received: from smtp.timeweb.ru (unknown [IPv6:2a03:6f00:1::5c35:743c])
 by mx1.freebsd.org (Postfix) with ESMTP id EB7628FC08;
 Tue, 11 Dec 2012 13:21:31 +0000 (UTC)
Received: from [213.148.20.85] (helo=hive.panopticon)
 by smtp.timeweb.ru with esmtpsa (TLSv1:DHE-RSA-CAMELLIA256-SHA:256)
 (Exim 4.80) (envelope-from <amdmi3@amdmi3.ru>)
 id 1TiPm5-0008DN-UF; Tue, 11 Dec 2012 17:21:29 +0400
Received: from hades.panopticon (hades.panopticon [192.168.0.32])
 by hive.panopticon (Postfix) with ESMTP id DB50AB84D;
 Tue, 11 Dec 2012 17:21:28 +0400 (MSK)
Received: by hades.panopticon (Postfix, from userid 1000)
 id C57505DF; Tue, 11 Dec 2012 17:21:28 +0400 (MSK)
Date: Tue, 11 Dec 2012 17:21:28 +0400
From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Subject: Re: svn commit: r308655 - in head/games/xmoto: . files
Message-ID: <20121211132128.GA50148@hades.panopticon>
References: <201212110314.qBB3EErH082058@svn.freebsd.org>
 <20121211033625.GA39028@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20121211033625.GA39028@FreeBSD.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Dec 2012 13:21:32 -0000

* Alexey Dokuchaev (danfe@FreeBSD.org) wrote:
> On Tue, Dec 11, 2012 at 03:14:14AM +0000, Dmitry Marakasov wrote:
> > New Revision: 308655
> > URL: http://svnweb.freebsd.org/changeset/ports/308655
> > 
> > +OPTIONS_DEFINE=	ASIAN_TTF
> >  
> > [...]
> >  
> > +.if ${PORT_OPTIONS:MNLS}
> > [...]
> > +.if ${PORT_OPTIONS:MDOCS}
> 
> Looks like these two should also be mentioned in OPTIONS_DEFINE.

Not adding them to OPTIONS_DEFINE preserves previous behaviour and I
don't think NLS and DOCS should be in the OPTIONS_DEFINE ever - they are
only meaningful to be set globally, and having them in individual ports
makes large builds much more painful, as a user has to set them for tons
of ports (even more painful without portmaster or knowing of
config-recursive).

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru