From owner-cvs-usrbin Thu Jul 2 07:19:55 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id HAA29788 for cvs-usrbin-outgoing; Thu, 2 Jul 1998 07:19:55 -0700 (PDT) (envelope-from owner-cvs-usrbin) Received: from ns1.yes.no (ns1.yes.no [195.119.24.10]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id HAA29713; Thu, 2 Jul 1998 07:19:35 -0700 (PDT) (envelope-from eivind@bitbox.follo.net) Received: from bitbox.follo.net (bitbox.follo.net [195.204.143.218]) by ns1.yes.no (8.8.7/8.8.7) with ESMTP id OAA27813; Thu, 2 Jul 1998 14:19:35 GMT Received: (from eivind@localhost) by bitbox.follo.net (8.8.8/8.8.6) id QAA17166; Thu, 2 Jul 1998 16:19:34 +0200 (MET DST) Message-ID: <19980702161934.17898@follo.net> Date: Thu, 2 Jul 1998 16:19:34 +0200 From: Eivind Eklund To: =?iso-8859-1?Q?S=F8ren_Schmidt?= , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-usrbin@FreeBSD.ORG Subject: Re: cvs commit: src/usr.bin/doscmd intff.c References: <199807021407.HAA05486@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Mailer: Mutt 0.89.1i In-Reply-To: =?iso-8859-1?Q?=3C199807021407=2EHAA05486=40freefall=2Efreebsd=2Eorg=3E?= =?iso-8859-1?Q?=3B_from_S=F8ren_Schmidt_on_Thu=2C_Jul_02=2C_1998_at_07?= =?iso-8859-1?Q?=3A07=3A33AM_-0700?= Sender: owner-cvs-usrbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Thu, Jul 02, 1998 at 07:07:33AM -0700, Søren Schmidt wrote: > sos 1998/07/02 07:07:32 PDT > > Modified files: > usr.bin/doscmd intff.c > Log: > Add missing ')'.. > > Doesn't anybody TEST code before committing.... > > This is the X'th time these laste couble of days... Several of these has been problems with LKMs. The problem is that we don't honour dependencies properly, and the LKMs is built at the wrong point (they should IMO just be the kernel object files). Forgetting the LKMs come pretty naturally if you don't do a buildworld for each kernel change (and many people don't - I've been one of themw). It is somewhat like you probably wouldn't do a buildworld for a manpage change... Eivind.