From owner-svn-src-head@freebsd.org  Wed Oct 21 12:15:13 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E5191A1AAD1
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Wed, 21 Oct 2015 12:15:13 +0000 (UTC)
 (envelope-from citrin+bsd@citrin.ru)
Received: from ost.citrin.ru (servers-nat.openstat.org [193.169.234.5])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id A25C0A21
 for <svn-src-head@freebsd.org>; Wed, 21 Oct 2015 12:15:12 +0000 (UTC)
 (envelope-from citrin+bsd@citrin.ru)
Received: from citrin.office.vega.ru (office-nat.openstat.org [193.169.234.6])
 (Authenticated sender: citrin@citrin.ru)
 by ost.citrin.ru (Postfix) with ESMTPSA id 92A956C12BFC
 for <svn-src-head@freebsd.org>; Wed, 21 Oct 2015 12:15:02 +0000 (UTC)
Subject: Re: svn commit: r289664 - head/sys/kern
To: svn-src-head@freebsd.org
References: <201510202038.t9KKcKW5064373@repo.freebsd.org>
 <5626A748.5040101@FreeBSD.org>
From: Anton Yuzhaninov <citrin+bsd@citrin.ru>
Message-ID: <562781C5.4060408@citrin.ru>
Date: Wed, 21 Oct 2015 15:15:01 +0300
User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <5626A748.5040101@FreeBSD.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrin.ru; s=s0;
 t=1445429702; bh=N2EPIhDNRBF8xbkmS3MMBhfBZWhhve3P4NQKxWMhPoI=;
 h=Subject:To:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding;
 b=uo3WLqYj7qveD4MA/O9jkQLwp/+tGCqfcUsa4Hk7vkIZZ7xKK8Jt548CR/5XuZrJK7hoBfAqe7OXE649GloVWvRiCORsgYnW+G7qS2xGDlPbBVkcu3IfjF6BxqlC9GANWK+NuDMifznJkt+aWZKKfmG7m2ngt4bsZJJMFflyhIM=
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Oct 2015 12:15:14 -0000

On 10/20/15 23:42, Bryan Drewery wrote:
> On 10/20/2015 1:38 PM, Konstantin Belousov wrote:
>> Author: kib
>> Date: Tue Oct 20 20:38:20 2015
>> New Revision: 289664
>> URL: https://svnweb.freebsd.org/changeset/base/289664
>>
>> Log:
>>    Trim spaces at end of line to record the proper commit message for
>>    r289660:
>
> I really think we should just do a full revert and recommit in these
> cases, and not even a forced commit.  Neither this commit or a forced
> commit will show in 'svn blame' or even during a bisect.  It really just
> becomes luck to find the right commit noting the message.  IMHO 'svn
> blame' is more important than some extra churn in 'svn log' or email. It
> does add more steps in 'svn blame' but it ends up giving the right
> message more obviously.
>
> I'm not asking to redo this commit now, but I think we should have a
> standard of just recommitting to fix mistakes.

Why
svn propedit svn:log --revprop -r289660
Is not used?
AFAIR this was disabled, because revprop edit can't be synced with CVS. But 
there is no official CVS repo for a log time.