From owner-svn-src-all@FreeBSD.ORG Sat Dec 11 08:07:21 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A76A91065674; Sat, 11 Dec 2010 08:07:21 +0000 (UTC) (envelope-from kevlo@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 9740E8FC43; Sat, 11 Dec 2010 08:07:21 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id oBB87L0X099231; Sat, 11 Dec 2010 08:07:21 GMT (envelope-from kevlo@svn.freebsd.org) Received: (from kevlo@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id oBB87LHd099229; Sat, 11 Dec 2010 08:07:21 GMT (envelope-from kevlo@svn.freebsd.org) Message-Id: <201012110807.oBB87LHd099229@svn.freebsd.org> From: Kevin Lo Date: Sat, 11 Dec 2010 08:07:21 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r216369 - head/lib/libipsec X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Dec 2010 08:07:21 -0000 Author: kevlo Date: Sat Dec 11 08:07:21 2010 New Revision: 216369 URL: http://svn.freebsd.org/changeset/base/216369 Log: The use of snprintf() to append to a buffer is not valid according to C99 Modified: head/lib/libipsec/ipsec_dump_policy.c Modified: head/lib/libipsec/ipsec_dump_policy.c ============================================================================== --- head/lib/libipsec/ipsec_dump_policy.c Sat Dec 11 00:36:35 2010 (r216368) +++ head/lib/libipsec/ipsec_dump_policy.c Sat Dec 11 08:07:21 2010 (r216369) @@ -162,7 +162,8 @@ ipsec_dump_policy(policy, delimiter) return NULL; } buf = newbuf; - snprintf(buf, buflen, "%s%s%s", buf, delimiter, isrbuf); + snprintf(buf + strlen(buf), buflen - strlen(buf), + "%s%s", delimiter, isrbuf); off += xisr->sadb_x_ipsecrequest_len; }