From owner-freebsd-current@freebsd.org Fri Feb 3 16:12:10 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1A6E0CCF536; Fri, 3 Feb 2017 16:12:10 +0000 (UTC) (envelope-from gpalmer@freebsd.org) Received: from mail.in-addr.com (mail.in-addr.com [IPv6:2a01:4f8:191:61e8::2525:2525]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DA64E8C7; Fri, 3 Feb 2017 16:12:09 +0000 (UTC) (envelope-from gpalmer@freebsd.org) Received: from gjp by mail.in-addr.com with local (Exim 4.88 (FreeBSD)) (envelope-from ) id 1cZgT2-0003hV-22; Fri, 03 Feb 2017 16:12:08 +0000 Date: Fri, 3 Feb 2017 16:12:07 +0000 From: Gary Palmer To: Ultima Cc: freebsd-stable@freebsd.org, freebsd-current@freebsd.org, freebsd-fs@freebsd.org Subject: Re: zfs snapshot_limit is not respected Message-ID: <20170203161207.GB68015@in-addr.com> References: <20170203124251.GA68015@in-addr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: gpalmer@freebsd.org X-SA-Exim-Scanned: No (on mail.in-addr.com); SAEximRunCond expanded to false X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2017 16:12:10 -0000 On Fri, Feb 03, 2017 at 10:27:48AM -0500, Ultima wrote: > Hey Gary, > > You are probably right. Do you know how to "lock" this property by chance? > I'v read this exact line several times trying to understand the exact > meaning. The "user is allowed to change the limit" I *think* is referring > to the zfs allow command. The problem is that I checked the dataset and it > is showing no permissions granted to a user. So I guess user in this case > is also including the root user, but how does one lock the property from > root? I keep going through the manpage looking for something I may have > missed but keep coming up empty. Hi, I suspect you can't lock root out, but you could allow a different user to create snapshots. If you use that user to create snapshots, they should be subject to the snapshot limit, assuming you don't let them change that property. Regards, Gary > Thanks for replying, > Ultima > > On Fri, Feb 3, 2017 at 7:42 AM, Gary Palmer wrote: > > > On Thu, Feb 02, 2017 at 09:31:58PM -0500, Ultima wrote: > > > I recently moved some data on a box with limited space. I decided I > > should > > > limit the snapshots so that space would not become an issue. I just check > > > back a week later to find out the box is hitting the borderline. Doing I > > > quick check I realized that the snapshot_limit is not being respected. > > > > > > # uname -a > > > FreeBSD R1 11.0-STABLE FreeBSD 11.0-STABLE #17 r312232: Sun Jan 15 > > 10:59:10 > > > EST 2017 root@S1:/usr/src/11-STABLE/obj/usr/src/11-STABLE/src/sys/ > > MYKERNEL > > > amd64 > > > > > > # zfs create zroot/bhyve/test > > > # zfs set snapshot_limit=0 zroot/bhyve/test > > > # zfs snapshot zroot/bhyve/test@1 > > > > > > > > > # zfs snapshot zroot/bhyve/test@2 > > > # zfs snapshot zroot/bhyve/test@3 > > > # zfs list -t snapshot | grep zroot/bhyve/test > > > zroot/bhyve/test@1 0 - > > > 88K - > > > zroot/bhyve/test@2 0 - > > > 88K - > > > zroot/bhyve/test@3 0 - > > > 88K - > > > # zfs get all zroot/bhyve/test | grep snapshot > > > zroot/bhyve/test usedbysnapshots 0 - > > > zroot/bhyve/test snapshot_limit 0 local > > > zroot/bhyve/test snapshot_count 3 local > > > > > > Also wanted to verify 0 was not being mistaken for none. > > > > > > # for snapshot in `zfs list -t snapshot | grep zroot/bhyve/test | awk > > > '{print $1}'`; do zfs destroy $snapshot ; done > > > > > > # zfs get all zroot/bhyve/test | grep snapshot > > > zroot/bhyve/test usedbysnapshots 0 - > > > zroot/bhyve/test snapshot_limit 0 local > > > zroot/bhyve/test snapshot_count 0 local > > > > > > # zfs set snapshot_limit=1 zroot/bhyve/test > > > # zfs snapshot zroot/bhyve/test@1 > > > # zfs snapshot zroot/bhyve/test@2 > > > # zfs snapshot zroot/bhyve/test@3 > > > # zfs get all zroot/bhyve/test | grep snapshot > > > zroot/bhyve/test usedbysnapshots 0 - > > > zroot/bhyve/test snapshot_limit 1 local > > > zroot/bhyve/test snapshot_count 3 local > > > > > > > > > Also tested on head > > > FreeBSD S1 12.0-CURRENT FreeBSD 12.0-CURRENT #26 r312388: Wed Jan 18 > > > 12:38:52 EST 2017 > > > root@S1:/usr/src/head/obj/usr/src/head/src/sys/MYKERNEL-NODEBUG > > > amd64 > > > > Hi, > > > > I suspect this line from the manpage is key: > > > > The limit is not enforced if the user is allowed to change the limit > > > > Regards, > > > > Gary > > > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >