From nobody Fri Jan 16 12:37:02 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dszrH0Fjmz6PD6G for ; Fri, 16 Jan 2026 12:37:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dszrG6fMmz43Zq for ; Fri, 16 Jan 2026 12:37:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768567022; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5YCvWZeF60Xa0d0n8vJIBjfHqeZdYa9q8QbkcuWqZ/c=; b=dYRAqL0ziZqou/7vFvf316oY9oUTuhHMgf1R4/XCkK/lZJOwjcKo7D3SE5wkOzvtMI3pch uLqLvQTWJ3HptvmpKfUBoOPLy44mFEjp0socI7cv7Mfy0SOVpPbzlrvU/VRYmxdvij/6QB cPAA5DrnncPkIVOvGSt3l/bIIooQDDmnbCqpPHggmqVEsmv6THl2Eqlv9y1MtOE/EUpsvt 3SA88l0crHck0iC+/sCQXd4lqzw8hrK6bzQxrrokicQFXN4Nuqxiy+BSrLR+qJDQIEP2QQ H5rDuGUNLepX2cvG/Fvg1U+bLAczRpQqI5msvVZga3UcNn9mz4Yxe9rTMLyKzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768567022; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5YCvWZeF60Xa0d0n8vJIBjfHqeZdYa9q8QbkcuWqZ/c=; b=ZAIar/FkQXe27x4jGhjZWgLcZ+1X1oCjmEWr3aEJSQdsM77sS+N86NzVKrtveoUlWSF4uS WhzFh8zyz8mXoT7gxEfTLE4kDAQ2ePbtClEI1OBxVU9KO2qwoEg76gib83Slviu7GFNTfI W74WgjsWbP6VrvNuMghzuvvQM0xbr+ojsoLCQ7UQP/SmVcYU18kc/WNmISLPPZ9TokzJHJ /9uI/sbwep55OMbjtbFB5Wp3+f1AMsugt74SOIF4z80KKNTVGAD+BWfh1nqZVhNlFdjbRR pZB7sAXqqUv16UEd+pPjQ2/3063Ylx9CLdIk6dAhxqg45wNIeNm6yAPNUrgnXA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1768567022; a=rsa-sha256; cv=none; b=OABLz6GWIunQl196NgREDvmvRrEpUUxVfZBjcxAZym9TeT5iYt/V6tPVcXJ0cvGF+lgOiL AUfWWX5SH4jp+5uO8OsongQlB1wvUYu/P+xOrICbUclELKOvViQeWvASHGM3YvmoU/QQOU jMWHfPD2UWqbKhN+9FyyGLeKckSUb/c+4Hs7ctQ6SoNGfAQnwc8Aj/ct534SajLHnVa8s/ geCqYtxr/8ec5nUxYutqIfU8eMjYr3VL91tl4lTPtDt+YJSOz/b+jO+YZwJuywux1W9mnk 1j4BrGL3Ws4Yjx8ZtcGZTW8AHeLMt4IShXYbP9cTqBxLMCy8Hzv19MenKaJ57Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dszrG5xRtzJr for ; Fri, 16 Jan 2026 12:37:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3bab4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 16 Jan 2026 12:37:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: bbd30927b1af - main - bge: disable TXCSUM if UDP transmit checksum offloading is disabled List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: bbd30927b1af44226c8de0512912a7fedfce2824 Auto-Submitted: auto-generated Date: Fri, 16 Jan 2026 12:37:02 +0000 Message-Id: <696a30ee.3bab4.e1e45c5@gitrepo.freebsd.org> The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=bbd30927b1af44226c8de0512912a7fedfce2824 commit bbd30927b1af44226c8de0512912a7fedfce2824 Author: Michael Tuexen AuthorDate: 2026-01-16 12:32:13 +0000 Commit: Michael Tuexen CommitDate: 2026-01-16 12:36:53 +0000 bge: disable TXCSUM if UDP transmit checksum offloading is disabled The bge interface is special with respect to transmit checksumi offloading. In the default settings, an bge interface announces TXCSUM capabilities, but only supports TCP/IPv4 and not UDP/IPv4 due to limitations of some of the NICs. This results in problems when the bge interface becomes a member of a bridge. Since currently only the TXCSUM capabilities are synced when a member is added to a bridge and not the protocol specific capabilities, this can result in a situation where UDP packets are sent out using a bge interface without having a correct checksum. To mitigate this problem, initially don't announce TXCSUM capabilities, when UDP transmit checksum is disabled. It is still possible to enable TXCSUM capabilities via ifconfig. PR: 291420 Reviewed by: Timo Voelker MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D54486 --- share/man/man4/bge.4 | 10 +++++++++- sys/dev/bge/if_bge.c | 14 +++++++++++++- 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/share/man/man4/bge.4 b/share/man/man4/bge.4 index de559c16df3c..fdf46fec0073 100644 --- a/share/man/man4/bge.4 +++ b/share/man/man4/bge.4 @@ -29,7 +29,7 @@ .\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF .\" THE POSSIBILITY OF SUCH DAMAGE. .\" -.Dd August 18, 2017 +.Dd January 16, 2026 .Dt BGE 4 .Os .Sh NAME @@ -276,3 +276,11 @@ Also, due to the lack of hotplug support, Thunderbolt-based interfaces must not while the system is up as the kernel is currently unable to cope with a .Nm interface disappearing. +.Pp +The UDP transmit checksum offloading is disabled by default, see +.Va dev.bge.%d.forced_udpcsum . +To avoid problems when the interface is a member of a +.Xr bridge 4 +interface, all transmit checksum offloading is initially disabled in this case. +Transmit checksum offloading can be enabled using +.Xr ifconfig 8 . diff --git a/sys/dev/bge/if_bge.c b/sys/dev/bge/if_bge.c index cf3084f9b768..2feb19bff677 100644 --- a/sys/dev/bge/if_bge.c +++ b/sys/dev/bge/if_bge.c @@ -3721,7 +3721,12 @@ bge_attach(device_t dev) if_setgetcounterfn(ifp, bge_get_counter); if_setsendqlen(ifp, BGE_TX_RING_CNT - 1); if_setsendqready(ifp); - if_sethwassist(ifp, sc->bge_csum_features); + /* Initially enable checksum offloading either for all of IPv4, TCP/IPv4 + * and UDP/IPv4, or for none. This avoids problems when the interface + * is added to a bridge. + */ + if (sc->bge_csum_features & CSUM_UDP) + if_sethwassist(ifp, sc->bge_csum_features); if_setcapabilities(ifp, IFCAP_HWCSUM | IFCAP_VLAN_HWTAGGING | IFCAP_VLAN_MTU); if ((sc->bge_flags & (BGE_FLAG_TSO | BGE_FLAG_TSO3)) != 0) { @@ -3732,6 +3737,13 @@ bge_attach(device_t dev) if_setcapabilitiesbit(ifp, IFCAP_VLAN_HWCSUM, 0); #endif if_setcapenable(ifp, if_getcapabilities(ifp)); + /* + * Disable TXCSUM capability initially, if UDP checksum offloading is + * not enabled. This avoids problems when the interface is added to a + * bridge. + */ + if ((sc->bge_csum_features & CSUM_UDP) == 0) + if_setcapenablebit(ifp, 0, IFCAP_TXCSUM); #ifdef DEVICE_POLLING if_setcapabilitiesbit(ifp, IFCAP_POLLING, 0); #endif