From owner-svn-src-stable-7@FreeBSD.ORG Mon Jan 12 08:53:42 2009 Return-Path: Delivered-To: svn-src-stable-7@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F3857106566B; Mon, 12 Jan 2009 08:53:41 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85]) by mx1.freebsd.org (Postfix) with ESMTP id D5C598FC12; Mon, 12 Jan 2009 08:53:41 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1]) by dragon.nuxi.org (8.14.2/8.14.2) with ESMTP id n0C8ViUb069542; Mon, 12 Jan 2009 00:31:44 -0800 (PST) (envelope-from obrien@dragon.nuxi.org) Received: (from obrien@localhost) by dragon.nuxi.org (8.14.2/8.14.2/Submit) id n0C8Vi4t069541; Mon, 12 Jan 2009 00:31:44 -0800 (PST) (envelope-from obrien) Date: Mon, 12 Jan 2009 00:31:44 -0800 From: "David O'Brien" To: Xin LI Message-ID: <20090112083144.GA69408@dragon.NUXI.org> References: <200901120039.n0C0dMKX043214@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200901120039.n0C0dMKX043214@svn.freebsd.org> X-Operating-System: FreeBSD 8.0-CURRENT User-Agent: Mutt/1.5.16 (2007-06-09) Cc: svn-src-stable@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, svn-src-stable-7@FreeBSD.org Subject: Re: svn commit: r187069 - stable/7/sbin/fsck_ffs X-BeenThere: svn-src-stable-7@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: SVN commit messages for only the 7-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jan 2009 08:53:42 -0000 On Mon, Jan 12, 2009 at 12:39:22AM +0000, Xin LI wrote: > Author: delphij > Date: Mon Jan 12 00:39:22 2009 > New Revision: 187069 > URL: http://svn.freebsd.org/changeset/base/187069 > > Log: > MFC revisions 178088 and 179656: Catastrophic recovery mode. Hi Xin, I guess you missed my email to you about this. I was hoping to get an answer to this before it was MFC'ed. The use of 'C' conflicts with a Juniper Networks change Juniper wants to push back to FreeBSD. For Juniper the -C flag is the "clean" flag. Meaning don't do anything if the FS is clean, other wise do as full a fsck as possible (vs. just a "preen" fsck). It is useful as 'fsck -C -y /var' (for instance). Do you think your functionality could live under the "-D" (damaged) option? fsck_ffs already had a "-c" option, or Juniper would have used that letter. -- -- David (obrien@FreeBSD.org) Q: Because it reverses the logical flow of conversation. A: Why is top-posting (putting a reply at the top of the message) frowned upon? Let's not play "Jeopardy-style quoting"