From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Feb 14 07:42:00 2015 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 42C88FF0 for ; Sat, 14 Feb 2015 07:42:00 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 28036E10 for ; Sat, 14 Feb 2015 07:42:00 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t1E7g0pd092789 for ; Sat, 14 Feb 2015 07:42:00 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 197582] games/assaultcube: convert to option helpers and dependency fixes Date: Sat, 14 Feb 2015 07:42:00 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: lightside@gmx.com X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Feb 2015 07:42:00 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197582 --- Comment #10 from lightside --- (In reply to comment #9) > This piece can probably go in separately but there're more warnings with clang > 3.6 or gcc 4.9 + -O3. At least one of them proved fatal for games/cube (see bug > 197604). I didn't mean to fix all the warnings, that more modern LLVM/Clang wrote, which is work of actual developers of the software. The software builds even without my patch. I saw, that across the source code the word "Couldn't" used, but in one place it is "Couldn`t", which was logical to fix, just for completeness. My approved patch in attachment 152933 is complete and this is what I think should be commited. Not the parts of it in review D1831, which requires PORTREVISION bump, while stated it is not. -- You are receiving this mail because: You are the assignee for the bug.