From owner-cvs-all Wed Nov 6 22:15: 2 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BFAF037B401; Wed, 6 Nov 2002 22:14:59 -0800 (PST) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id EF11C43E75; Wed, 6 Nov 2002 22:14:58 -0800 (PST) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id gA76EtB6016554; Thu, 7 Nov 2002 07:14:56 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Hidetoshi Shimokawa Cc: Hidetoshi Shimokawa , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/nge if_nge.c if_ngereg.h In-Reply-To: Your message of "Thu, 07 Nov 2002 11:33:49 +0900." Date: Thu, 07 Nov 2002 07:14:55 +0100 Message-ID: <16553.1036649695@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message , Hidetoshi Shimokawa writes : >> > Modified files: >> > sys/dev/nge if_nge.c if_ngereg.h >> > Log: >> > Add support for DEVICE_POLLING. >> > >> Hang on for a second: >> >> This chip supports interrupt pacing so I would like to see >> some documentation for an improvement from DEVICE_POLLING over >> tuning the interrupt pacing in the chip, before we even think >> about MFC, much less let this commit stay in the tree. > >I think interrupt pacing usually does good job too. > >But still, I think there could be some cases device polling does >better job (ex. multiple busy NICs.) and it's a good thing >to give a option to users. > >> What tests have been run ? >> What are the numbers ? (and please, include a standard deviation!) > >I don't have any numbers by myself. I'm asking for the original author >whether he has. Yes please. Unless there is documentation that this actually helps, it should be backed out. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message