Date: Thu, 07 Nov 2002 07:14:55 +0100 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Hidetoshi Shimokawa <simokawa@sat.t.u-tokyo.ac.jp> Cc: Hidetoshi Shimokawa <simokawa@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/nge if_nge.c if_ngereg.h Message-ID: <16553.1036649695@critter.freebsd.dk> In-Reply-To: Your message of "Thu, 07 Nov 2002 11:33:49 %2B0900." <ybsu1iuhzw2.wl@ett.sat.t.u-tokyo.ac.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <ybsu1iuhzw2.wl@ett.sat.t.u-tokyo.ac.jp>, Hidetoshi Shimokawa writes : >> > Modified files: >> > sys/dev/nge if_nge.c if_ngereg.h >> > Log: >> > Add support for DEVICE_POLLING. >> > >> Hang on for a second: >> >> This chip supports interrupt pacing so I would like to see >> some documentation for an improvement from DEVICE_POLLING over >> tuning the interrupt pacing in the chip, before we even think >> about MFC, much less let this commit stay in the tree. > >I think interrupt pacing usually does good job too. > >But still, I think there could be some cases device polling does >better job (ex. multiple busy NICs.) and it's a good thing >to give a option to users. > >> What tests have been run ? >> What are the numbers ? (and please, include a standard deviation!) > >I don't have any numbers by myself. I'm asking for the original author >whether he has. Yes please. Unless there is documentation that this actually helps, it should be backed out. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?16553.1036649695>