From owner-freebsd-mips@FreeBSD.ORG Mon Mar 15 14:30:31 2010 Return-Path: Delivered-To: mips@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7D3FB106566B for ; Mon, 15 Mar 2010 14:30:31 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 3E5E88FC19 for ; Mon, 15 Mar 2010 14:30:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o2FENNoG008533; Mon, 15 Mar 2010 08:23:23 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 15 Mar 2010 08:23:34 -0600 (MDT) Message-Id: <20100315.082334.1032464807170521414.imp@bsdimp.com> To: ray@ddteam.net From: "M. Warner Losh" In-Reply-To: <20100315111756.05fd5805.ray@ddteam.net> References: <20100314.181902.67053632336017068.imp@bsdimp.com> <20100315111756.05fd5805.ray@ddteam.net> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: mips@FreeBSD.org Subject: Re: Request for review: AR71XX config cleanup X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Mar 2010 14:30:31 -0000 In message: <20100315111756.05fd5805.ray@ddteam.net> Alex RAY writes: : Maybe umass and SCSI modules relocate from the std files to config files? I'm a little on the fence here. std.foo is supposed to have all the things that are in GENERIC. In fact, I see sys/i386/GENERIC eventually being: ident GENERIC include "std.i386" So, if we view it from that point of view, it becomes clear that we want to include the usb/scsi stuff in std.ar71xx. They are easy enough to omit if you had a system without usb: include "std.ar71xx" nodevice usb nodevice umass nodevice scbus nodevice da wouldn't be a horrible burden on people. But then again, USB on x86 includes everything, whereas I've only include umass. If I'm going to subset, why this subset. How would others know what the right subset would be for their boards, etc. So that's why I'm on the fence. Once you start getting into the "this is sensible" game, then you have to start making seasoned judgements. Without a better definition of what a 'generic' kernel should have, or shouldn't have, I'm not sure there's a better way. Warner