From owner-freebsd-current@freebsd.org Mon Jan 29 12:50:16 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 39D88EC4E88 for ; Mon, 29 Jan 2018 12:50:16 +0000 (UTC) (envelope-from maurizio1018@gmail.com) Received: from mail-pf0-x22b.google.com (mail-pf0-x22b.google.com [IPv6:2607:f8b0:400e:c00::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AF0BB71166; Mon, 29 Jan 2018 12:50:15 +0000 (UTC) (envelope-from maurizio1018@gmail.com) Received: by mail-pf0-x22b.google.com with SMTP id 23so5070460pfp.3; Mon, 29 Jan 2018 04:50:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8PlmQjk4DLH4lT9BUzXz42Yc3tmsRWcY0l2p0lBOnfY=; b=hTzxTutl1L833/IrpPdekkVB0p/wVANshWy3uhMhbWTrLN/pxwDUnFEqNfadKXSgKc fdKX5Z/pgZw7B+lgjtsqTuC6ZhuMmwNHjCHwqZ7I/0EpEs74ZiBf5QheHCT73tiG1zA5 KEZqCAV45KGdyehSbly9HpFhv7ce7CqrbWqrUIDMp4CeduJl5AW5bSd3OmaDa8E8YiMX OkR9l050rm/bd1Rr8MwYzLpia2PrGjmIPm+ZSM/jyZerT28HyeAvx0daDzBXvucHXwR9 CcRVOdd6Ss/hh849dvUuzC0/Hel/CRwuZqmp8JtNpWaQRbLHRS/32VIqzb4YNaHFbww3 o5JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8PlmQjk4DLH4lT9BUzXz42Yc3tmsRWcY0l2p0lBOnfY=; b=UTujYwEm3O68a5JN+dTFiP3haFbyBSNddSXXaNrSFTzv01PSIWqwp0idoXsNnv68W3 YbixIZ6PFoRKdsV9V7yXPlmraZyYOh7SDHA90QmaR5eA7UFtCLFwmRRrgitvSHF+Ejug NE4xtB+45+dqUGQR+XNgTL28r3TKsIvyfOxCYMVGHI0CuQk2w1+AEWNpZuUKEbly0ZuW fEcl7Vo7VAlUluZiVnQbJj+bPHbvGfF75nn6qZJAsePv/Wm/21KEuDSsXN8MYmCINIAn phAqHNiPnC1HVEVAQt8wj+4karS4epS9Y8SAHp/jegzptd+XrPT70sIBovsjA5I+6lJg FahA== X-Gm-Message-State: AKwxytfVc8CmVnQDjtvtBTXkcuUh7PeF/Mn7E4CLFfjbosdiszE6o+wW VwaMbnldAV+LAxnRvy7UVkx+WuV30wi2tuoL4pY= X-Google-Smtp-Source: AH8x226Bv42xqStfuBVGAXDvT0qgmUVuUx1mc3p17RI3uQ6IhX2CvgLm1ybqPdWTisSW8KtqpSLbWO6VXDT8Z6uOMic= X-Received: by 10.99.112.81 with SMTP id a17mr12583168pgn.293.1517230214544; Mon, 29 Jan 2018 04:50:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.100.138.144 with HTTP; Mon, 29 Jan 2018 04:50:14 -0800 (PST) In-Reply-To: <1517070032.84051.6.camel@freebsd.org> References: <9D0C6C9E-3020-4EC0-97AF-6498FB7356C7@jnielsen.net> <1516988137.42536.255.camel@freebsd.org> <09C92929-BC36-4C75-A2F2-0607C9701D40@jnielsen.net> <1517070032.84051.6.camel@freebsd.org> From: Maurizio Vairani Date: Mon, 29 Jan 2018 13:50:14 +0100 Message-ID: Subject: Re: Error compiling isboot-kmod To: Ian Lepore Cc: John Nielsen , freebsd-current , Warner Losh Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jan 2018 12:50:16 -0000 2018-01-27 17:20 GMT+01:00 Ian Lepore : > On Fri, 2018-01-26 at 23:20 -0700, John Nielsen wrote: > > > > > > On Jan 26, 2018, at 9:42 PM, John Nielsen wrote: > > > > > > > > > > > [...] > > > --- iscsi.o --- > > > iscsi.c:1146:3: error: incompatible pointer types passing 'void > (struct mbuf *, void *, void *)' to parameter of type 'm_ext_free_t *' (aka > 'void (*)(struct mbuf *)') [-Werror,-Wincompatible-pointer-types] > > > MEXTADD(md, (caddr_t)ds_dd, (ISCSI_ALIGN(pp->ds_len) > > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > /usr/src/sys/sys/mbuf.h:887:42: note: expanded from macro 'MEXTADD' > > > m_extadd((m), (char *)(buf), (size), (free), (arg1), > (arg2), \ > > > ^~~~~~ > > > /usr/src/sys/sys/mbuf.h:634:59: note: passing argument to parameter > here > > > void m_extadd(struct mbuf *, char *, u_int, m_ext_free_t, > > Looks like iscsi.c needs to be fixed up following r324446 > > (https://svnweb.freebsd.org/changeset/base/324446). Starting to be > > out of my depth unless there's a mechanical way to make the changes? > > > > > > I'm not set up to test-compile this against -current right now, so I'm > not sure if this is all that remains or just another breadcrumb on the > trail, but... try the attached patch. > > -- Ian > > --- iscsi.c.orig 2018-01-27 08:43:26.937858000 -0700 > +++ iscsi.c 2018-01-27 09:15:39.631501000 -0700 > @@ -1071,17 +1071,23 @@ > } > > > -#if __FreeBSD_version >= 1100000 > +#if __FreeBSD_version >= 1200051 > +static void > +isboot_free_mbufext(struct mbuf *m) > +{ > + void *p = m->m_ext.ext_arg1; > +#elif __FreeBSD_version >= 1100000 > static void > isboot_free_mbufext(struct mbuf *m, void *p, void *optarg) > #elif __FreeBSD_version >= 1000050 && __FreeBSD_version < 1100000 > static int > isboot_free_mbufext(struct mbuf *m, void *p, void *optarg) > +{ > #else > static void > isboot_free_mbufext(void *p, void *optarg) > -#endif > { > +#endif > > ISBOOT_TRACE("isboot_free_mbufext\n"); > if (p == NULL) > > Applying this patch the module is compilable, but when I use it I receive a 'Fatal trap 12'. I will open a new discussion. Thanks to all of you. Maurizio