From owner-freebsd-current@FreeBSD.ORG Thu Sep 4 02:25:32 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 14EA216A4BF; Thu, 4 Sep 2003 02:25:32 -0700 (PDT) Received: from prg.traveller.cz (prg.traveller.cz [193.85.2.77]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8545343FE3; Thu, 4 Sep 2003 02:25:30 -0700 (PDT) (envelope-from mime@traveller.cz) Received: from prg.traveller.cz (localhost [127.0.0.1]) h849PNtU044919; Thu, 4 Sep 2003 11:25:24 +0200 (CEST) Received: from localhost (mime@localhost)id h849PNVU044913; Thu, 4 Sep 2003 11:25:23 +0200 (CEST) Date: Thu, 4 Sep 2003 11:25:23 +0200 (CEST) From: Michal Mertl To: Jens Rehsack In-Reply-To: <3F56651C.5050108@liwing.de> Message-ID: <20030904101622.T32195@prg.traveller.cz> References: <3F56651C.5050108@liwing.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: roger@freebsd.org cc: gurney_j@efn.org cc: current@freebsd.org Subject: Re: bktr(4) bufs plus patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Sep 2003 09:25:32 -0000 On Wed, 3 Sep 2003, Jens Rehsack wrote: > Michal Mertl wrote: > > I found 2 bugs and some potential problems in bktr(4) code. > > > > Bug 1: > > Compilation with options BKTR_USE_FREEBSD_SMBUS failes. Error is > > that code tries to use iicbus which isn't defined where it looks for > > it. I added it there and the compilation and detection goes fine. I don't > > know how to actually test it though. > > > > [...] > > Will anyone responsible take notice of this patch and commit it? > > > ------------------------------------------------------------------------ > > > > *** dev/bktr/bktr_reg.h.ori Sun Dec 8 10:40:14 2002 > > --- dev/bktr/bktr_reg.h Sun Dec 8 10:40:38 2002 > > *************** > > *** 448,453 **** > > --- 448,454 ---- > > struct bktr_i2c_softc { > > int bus_owned; > > > > + device_t iicbus; > > device_t iicbb; > > device_t smbus; > > }; > > *** dev/bktr/bktr_os.c.ori Sun Dec 8 10:39:13 2002 > > --- dev/bktr/bktr_os.c Sun Dec 8 10:39:35 2002 > > *************** > > *** 499,513 **** > > destroy_dev(bktr->tunerdev); > > destroy_dev(bktr->bktrdev); > > > > - /* If this is unit 0, then destroy the alias entries too */ > > - #if (__FreeBSD_version >=500000) > > - if (unit == 0) { > > - destroy_dev(bktr->vbidev_alias); > > - destroy_dev(bktr->tunerdev_alias); > > - destroy_dev(bktr->bktrdev_alias); > > - } > > - #endif > > - > > /* > > * Deallocate resources. > > */ > > --- 499,504 ---- The destroy_dev calls for aliases have been removed in -current on 9th Dec 2002 (one day after I sent the email). See PR kern/36413. The fix hasn't been MFCed but there's no need - the code is wrapped in '#if (__FreeBSD_version >= 500000)'. The fix for BKTR_USE_FREEBSD_SMBUS hasn't been commited. I didn't send-pr but will recheck the status of things over the weekend and perhaps will do. To other readers: in my original email (http://docs.freebsd.org/cgi/getmsg.cgi?fetch=2276+0+archive/2002/freebsd-current/20021215.freebsd-current) I talked about another problem (limits on the maximum number of devices). When I reread what I wrote at the time I have to say 'sorry for my English' :-). -- Michal Mertl