From owner-freebsd-stable@FreeBSD.ORG Thu Aug 9 18:48:32 2012 Return-Path: Delivered-To: stable@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0E388106564A; Thu, 9 Aug 2012 18:48:32 +0000 (UTC) (envelope-from h.schmalzbauer@omnilan.de) Received: from host.omnilan.net (s1.omnilan.net [62.245.232.135]) by mx1.freebsd.org (Postfix) with ESMTP id 6D1A48FC14; Thu, 9 Aug 2012 18:48:30 +0000 (UTC) Received: from titan.inop.wdn.omnilan.net (titan.inop.wdn.omnilan.net [172.21.3.1]) (authenticated bits=0) by host.omnilan.net (8.13.8/8.13.8) with ESMTP id q79Imbci084650 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 9 Aug 2012 20:48:37 +0200 (CEST) (envelope-from h.schmalzbauer@omnilan.de) Message-ID: <502405F7.6070404@omnilan.de> Date: Thu, 09 Aug 2012 20:48:23 +0200 From: Harald Schmalzbauer Organization: OmniLAN User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; de-DE; rv:1.9.2.8) Gecko/20100906 Lightning/1.0b2 Thunderbird/3.1.2 MIME-Version: 1.0 To: attilio@FreeBSD.org References: <5022840B.3060708@omnilan.de> In-Reply-To: X-Enigmail-Version: 1.1.2 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig34E9508A3906AABEC440D3CF" Cc: stable@FreeBSD.org, daichi@FreeBSD.org, Pavel Polyakov Subject: Re: lock violation in unionfs (9.0-STABLE r230270) X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2012 18:48:32 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig34E9508A3906AABEC440D3CF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable schrieb Attilio Rao am 09.08.2012 20:26 (localtime): > On 8/8/12, Harald Schmalzbauer wrote: >> schrieb Pavel Polyakov am 06.03.2012 11:20 (localtime): >>>>> mount -t unionfs -o noatime /usr /mnt >>>>> >>>>> insmntque: mp-safe fs and non-locked vp: 0xfffffe01d96704f0 is not >>>>> exclusive locked but should be >>>>> KDB: enter: lock violation >>>> Pavel, >>>> can you give a spin to this patch?: >>>> http://www.freebsd.org/~attilio/unionfs_missing_insmntque_lock.patch= >>>> >>>> I think that the unlocking is due at that point as the vnode lock ca= n >>>> be switch later on. >>>> >>>> Let me know what you think about it and what the test does. >>> Thanks! >>> This patch fixes the problem with lock violation. Sorry I've tested i= t so >>> late. >> Hello, >> >> this patch still applies cleanly to RELENG_9_1. Was there another fix >> for the issue or has it just not been PR-sent and thus forgotten? > Can you and Pavel try the attached patch? Unfortunately I had no time > to test it, I just made in 5 free mins from a non-FreeBSD workstation, > then you should be able to tell me if it works or not, even compiling > it on a RELENG_9_1. > Please try with INVARIANTS option on Unfortunately I don't have a spare machine handy, but I ran a kernel compile job in our lab and at least I can confirm that it applies + compiles fine (i386 target on amd64, RELENG_9_1, options UNIONFS static included on a heavy-nodevice-over-GENERIC kernel). Thanks, -Harry P.S.: I'll have a nice testing machine vacant soon, so if no one else has time to test, I can come back in about 2 weeks with results. But that's far too late for 9.1-RELEASE I guess. --------------enig34E9508A3906AABEC440D3CF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iEYEARECAAYFAlAkBfcACgkQLDqVQ9VXb8iW8gCgvi4tg7xjVGO4FftcFCHPJzt8 OEwAoM4RF9ABALbttFjPrGLfeIVmbp3z =DWLh -----END PGP SIGNATURE----- --------------enig34E9508A3906AABEC440D3CF--