From owner-svn-src-all@freebsd.org Wed Jan 20 01:40:40 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0293CA885ED; Wed, 20 Jan 2016 01:40:40 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id D9FED1E3A; Wed, 20 Jan 2016 01:40:39 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id D3BA215B5; Wed, 20 Jan 2016 01:40:39 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 79DDA1C7BB; Wed, 20 Jan 2016 01:40:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id SjmSEMvh0njF; Wed, 20 Jan 2016 01:40:37 +0000 (UTC) Subject: Re: svn commit: r291941 - in head: lib/libpam/modules/pam_ssh secure/lib/libssh secure/libexec/sftp-server secure/libexec/ssh-keysign secure/libexec/ssh-pkcs11-helper secure/usr.bin/scp secure/usr.bin/... DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com D7FBB1C7B6 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201512071608.tB7G89BZ095366@repo.freebsd.org> <86vb6phdug.fsf@desk.des.no> <569E60BA.6050007@FreeBSD.org> <569E7524.5040806@FreeBSD.org> <569ED796.6030300@FreeBSD.org> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <569EE596.9060503@FreeBSD.org> Date: Tue, 19 Jan 2016 17:40:38 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <569ED796.6030300@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Sewi5EtjANkLnC8UD6lVcahR6aQbJ6t7Q" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jan 2016 01:40:40 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Sewi5EtjANkLnC8UD6lVcahR6aQbJ6t7Q Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 1/19/2016 4:40 PM, Bryan Drewery wrote: > On 1/19/2016 9:40 AM, Bryan Drewery wrote: >> On 1/19/2016 8:13 AM, Bryan Drewery wrote: >>> On 1/19/2016 5:56 AM, Dag-Erling Sm=C3=B8rgrav wrote: >>>> Bryan Drewery writes: >>>>> Log: >>>>> Replace unneeded manual dependency on header by adding it to SRCS= =2E >>>>> =20 >>>>> bsd.lib.mk and bsd.prog.mk already depend all objs on headers in = SRCS if >>>>> there is not yet a depend file. The headers in SRCS are never bu= ilt or >>>>> installed. After 'make depend' the header was already added as a= proper >>>>> dependency on the objects where needed. >>>> >>>> This doesn't work. Try the following: >>>> >>>> $ cd /usr/src/secure/lib/libssh >>>> $ make depend && make >>>> $ touch /usr/src/crypto/openssh/ssh_namespace.h >>>> $ make >>> >>> Well, it sort of works with WITH_FAST_DEPEND which will be default ve= ry >>> shortly. >>> >> ... >>>> $ grep -c ssh_namespace $(make -V.OBJDIR)/.depend >>>> 0 >>>> >>> >>> That is expected. The dependency is defined in bsd.lib.mk. Granted it= is >>> dependent on .depend existing, but I am going to remove that check so= it >>> is always defined. >>> >> >> The problem with the old method (mkdep which is still default) is that= >> the -include is not passed to mkdep. FAST_DEPEND does not have that >> issue since it generates the .depend files during compilation, where t= he >> -include is present. >> >> >=20 > It's manifesting for people now with -DNO_CLEAN using mkdep. I'm workin= g > on a solution rather than reverting. >=20 > /usr/obj/usr/src/tmp/usr/lib/libprivatessh.so: undefined reference to > `Fssh_crypto_scalarmult_curve25519' >=20 r294370 should fix it all. --=20 Regards, Bryan Drewery --Sewi5EtjANkLnC8UD6lVcahR6aQbJ6t7Q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWnuWWAAoJEDXXcbtuRpfP5uAH/0akaYphFjbqzmC6ZYW4/+iZ mwjvSodSpPWrmLMI+GyrHvDD7eSgb1M9jz//4S4LWoiRnSqVHVMAHT6beoC2vGbt daP0pRwQTnIQfa2TyPYnRO0TSdRFBu9GJc3aUuzuY9S+o+uubMlfo2G5lbfvPB5Q Cl8mJLIuu3pXBQO04AEOCv/vXsCGNLCE471vSamvvMEP1glsxnx7/wi5EZjid914 H/4K55JLdUGPQTuA3SjwCOddOJXnDWa4LmYPZOQqpvdFrmcIANP+l7qUNWczpVNH lenFYbKutKdVePpF9nQS3YIprsQ2i9tmErDy2iwlaOmIKC/IkKFsTUAC3YCNw+U= =94xr -----END PGP SIGNATURE----- --Sewi5EtjANkLnC8UD6lVcahR6aQbJ6t7Q--