From owner-freebsd-fs@freebsd.org Sun Sep 20 21:41:08 2015 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D998DA06C08 for ; Sun, 20 Sep 2015 21:41:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C57B8128A for ; Sun, 20 Sep 2015 21:41:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t8KLf8Ro065490 for ; Sun, 20 Sep 2015 21:41:08 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-fs@FreeBSD.org Subject: [Bug 203134] [nfs] [nlm] [lor] newnfs/allproc lock order reversal on NFS mount recovery Date: Sun, 20 Sep 2015 21:41:08 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.2-BETA2 X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rmacklem@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-fs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc bug_status resolution Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Sep 2015 21:41:08 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203134 Rick Macklem changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rmacklem@FreeBSD.org Status|New |Closed Resolution|--- |DUPLICATE --- Comment #1 from Rick Macklem --- The info below doesn't seem to show where the locks are acquired in the other order. The NFS client (for NFSv4) and the NLM first lock the NFS vnode and then the "proc" related lock(s). Since I do not believe the NFS subsystem and NLM (not really a part of NFS, but a separate protocol) ever first locks the proc structure and then a vnode, I don't think and deadlock can occur. If someone knows of a way that the generic kernel code could lock an NFS client vnode after acquiring a proc lock, please let me know. I do know that it isn't practical to "fix" these LORs, but I do not believe that they can cause deadlocks. If I find out where harmless LORs are listed, I'll add these. rick ps: Although 203133 isn't the same LOR, the same story applies to both. *** This bug has been marked as a duplicate of bug 203133 *** -- You are receiving this mail because: You are the assignee for the bug.