From owner-svn-src-all@freebsd.org Wed Jan 24 19:40:11 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0134EEC16B3; Wed, 24 Jan 2018 19:40:11 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f50.google.com (mail-it0-f50.google.com [209.85.214.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8E98873C3C; Wed, 24 Jan 2018 19:40:10 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f50.google.com with SMTP id x42so6481527ita.4; Wed, 24 Jan 2018 11:40:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=CZrnInW0mqGAHBDxeOE+4Ca0+NcMZY8rVb4r3Tui6CM=; b=JR5NFTb7wAdp9lz+hZpAgJJDbSESyr9N3SFPNNOU00CzPqRy6ja5+yExSdCjMt4Hid Nq+PFm84q9h0iciWVlFWumq9ur7bjAVuhu+NwJS36tgquFzFM/93rWdyDpmGNiULlY8h GjB1+n8x62QbXibtzNrjHb7R0Bdtr4v6mXaEzn6s4fSta3C4LpfsYSDiD6cjlfe2+fsQ EdabMu36PZHz1533eKccu4RG/qyYhFct6ZRTZAbjJp5THLFUmHvbxDwofRWyD+pvMUzY zREVdnRxs2rqFLpS/hROlSWPNZAfHOIY+2eXTh9P4NWoNoomneoHqrNuwksxGaSThuvt IEnQ== X-Gm-Message-State: AKwxytfUCDRI7FlN5RKTpCp4LoT8icyGTvpvappgbbrZLUFVC3T9ImNx HEbBjhIrlsXQWYha0sKxCtMbY+9E X-Google-Smtp-Source: AH8x2241Yof9+JCoAEf8yUguPRQdxKQHNG0ui/rMFNXGmbfn7LfgCmimODO5VzicVFHUZFEAPK4ssw== X-Received: by 10.36.6.143 with SMTP id 137mr10069225itv.34.1516822804227; Wed, 24 Jan 2018 11:40:04 -0800 (PST) Received: from mail-io0-f181.google.com (mail-io0-f181.google.com. [209.85.223.181]) by smtp.gmail.com with ESMTPSA id 137sm577617ioo.22.2018.01.24.11.40.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Jan 2018 11:40:04 -0800 (PST) Received: by mail-io0-f181.google.com with SMTP id l17so6049486ioc.3; Wed, 24 Jan 2018 11:40:03 -0800 (PST) X-Received: by 10.107.15.89 with SMTP id x86mr10122966ioi.38.1516822803739; Wed, 24 Jan 2018 11:40:03 -0800 (PST) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.2.95.152 with HTTP; Wed, 24 Jan 2018 11:40:03 -0800 (PST) In-Reply-To: References: <201801211542.w0LFgbsp005980@repo.freebsd.org> <51ff8aef-5660-7857-e4d5-12cdc77bc071@FreeBSD.org> <20180124182548.X1063@besplex.bde.org> <1516817048.42536.182.camel@freebsd.org> <2aa48cbd-247a-66cd-b486-02ee77ec2e96@selasky.org> From: Conrad Meyer Date: Wed, 24 Jan 2018 11:40:03 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev/... To: Warner Losh Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 19:40:11 -0000 On Wed, Jan 24, 2018 at 11:27 AM, Warner Losh wrote: > > Which is why we should add check overflows for most of the no wait cases. > They should be checked, but not primarily with mallocarray... I don't understand what the distinction is here. Can you help me understand why the overflow check should be lifted from mallocarray into the caller for no wait cases? Or is that not what you're suggesting? Thanks, Conrad