From owner-freebsd-bugs@FreeBSD.ORG  Fri Apr  2 14:10:12 2010
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8D517106566B
	for <freebsd-bugs@hub.freebsd.org>;
	Fri,  2 Apr 2010 14:10:12 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 630D08FC13
	for <freebsd-bugs@hub.freebsd.org>;
	Fri,  2 Apr 2010 14:10:12 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o32EACvd020899
	for <freebsd-bugs@freefall.freebsd.org>; Fri, 2 Apr 2010 14:10:12 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o32EACgL020898;
	Fri, 2 Apr 2010 14:10:12 GMT (envelope-from gnats)
Date: Fri, 2 Apr 2010 14:10:12 GMT
Message-Id: <201004021410.o32EACgL020898@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/107439: commit references a PR
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Apr 2010 14:10:12 -0000

The following reply was made to PR kern/107439; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/107439: commit references a PR
Date: Fri,  2 Apr 2010 14:03:56 +0000 (UTC)

 Author: kib
 Date: Fri Apr  2 14:03:43 2010
 New Revision: 206094
 URL: http://svn.freebsd.org/changeset/base/206094
 
 Log:
   Supply default implementation of VOP_RENAME() that does neccessary
   unlocks and unreferences for argument vnodes, as expected by
   kern_renameat(9), and returns EOPNOTSUPP. This fixes locks and
   reference leaks when rename is attempted on fs that does not
   implement rename.
   
   PR:	kern/107439
   Based on submission by:	Mikolaj Golub <to.my.trociny gmail com>
   Tested by:	Mikolaj Golub
   MFC after:	1 week
 
 Modified:
   head/sys/kern/vfs_default.c
 
 Modified: head/sys/kern/vfs_default.c
 ==============================================================================
 --- head/sys/kern/vfs_default.c	Fri Apr  2 14:03:01 2010	(r206093)
 +++ head/sys/kern/vfs_default.c	Fri Apr  2 14:03:43 2010	(r206094)
 @@ -67,6 +67,7 @@ __FBSDID("$FreeBSD$");
  #include <vm/vnode_pager.h>
  
  static int	vop_nolookup(struct vop_lookup_args *);
 +static int	vop_norename(struct vop_rename_args *);
  static int	vop_nostrategy(struct vop_strategy_args *);
  static int	get_next_dirent(struct vnode *vp, struct dirent **dpp,
  				char *dirbuf, int dirbuflen, off_t *off,
 @@ -113,6 +114,7 @@ struct vop_vector default_vnodeops = {
  	.vop_poll =		vop_nopoll,
  	.vop_putpages =		vop_stdputpages,
  	.vop_readlink =		VOP_EINVAL,
 +	.vop_rename =		vop_norename,
  	.vop_revoke =		VOP_PANIC,
  	.vop_strategy =		vop_nostrategy,
  	.vop_unlock =		vop_stdunlock,
 @@ -206,6 +208,20 @@ vop_nolookup(ap)
  }
  
  /*
 + * vop_norename:
 + *
 + * Handle unlock and reference counting for arguments of vop_rename
 + * for filesystems that do not implement rename operation.
 + */
 +static int
 +vop_norename(struct vop_rename_args *ap)
 +{
 +
 +	vop_rename_fail(ap);
 +	return (EOPNOTSUPP);
 +}
 +
 +/*
   *	vop_nostrategy:
   *
   *	Strategy routine for VFS devices that have none.
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"